review: refactor: rework CtGenerationTest to minimize unrelated diff #5744
+119
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirYwell
commented
Apr 7, 2024
| @@ -2625,4 +2620,9 @@ public <T, U> void setValue(T element, U value) { | |||
| castTarget(element).setAccessedType(castValue(value)); | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I have no clue why this changed now, feel free to debug :)
SirYwell
force-pushed
the
refactor/ctgenerationtest
branch
from
a1b2d3f
to
83d03e1
Compare
MartinWitt
reviewed
Apr 17, 2024
Comment on lines
69
to
74
| op = s -> { | ||
| if (s.isEmpty()) { | ||
| return " *"; | ||
| } | ||
| return (" * " + s); | ||
| }; |
There was a problem hiding this comment.
maybe this is the once in a lifetime place for s.isEmpty ? " *" : " * " + s ?
SirYwell
changed the title
I-Al-Istannen
requested changes
Apr 20, 2024
Comment on lines
228
to
245
| private void configurePrinter(Launcher launcher) { | ||
| Environment environment = launcher.getEnvironment(); | ||
| environment.setPrettyPrinterCreator(new Supplier<>() { | ||
| @Override | ||
| public PrettyPrinter get() { | ||
| // we want to create a printer configured for the given environment, | ||
| // but we are who creates this printer - juggle around this StackOverflowError | ||
| environment.setPrettyPrinterCreator(null); | ||
| DefaultJavaPrettyPrinter printer = (DefaultJavaPrettyPrinter) environment.createPrettyPrinter(); | ||
| environment.setPrettyPrinterCreator(this); | ||
| PrinterHelper printerHelper = new PrinterHelper(environment); | ||
| printerHelper.setPrefixBlockComments(true); | ||
| printer.setPrinterTokenWriter(new DefaultTokenWriter(printerHelper)); | ||
| return printer; | ||
| } | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you use tabs here instead of spaces to be consistent and fix the indentation of the comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the work on Java 21 features and #5674 we noticed that
CtGenerationTestalways generates diffs for the license headers and file endings.This PR aims to clean up the code to allow generating the exactly same content, especially
*prefixesI'm not sure if it makes sense to change the printer behavior this way, I'm open for better ideas.