add profiling timings for LLVM passes #50951
Conversation
| PIC->registerAfterPassCallback([isMetaPass](StringRef PassID, Any IR, | ||
| const PreservedAnalyses &PassPA) { | ||
| if (isMetaPass(PassID)) return; | ||
| if (jl_get_pgcstack() == NULL) return; |
There was a problem hiding this comment.
Any opinions about this @topolarity
There was a problem hiding this comment.
We don't need the jl_get_pgcstack() == NULL check any more, but it'd be really nice to implement #50926 (review) so that we're not just hiding LLVM work on its dedicated imaging threads
I'm going to take a whack at that later this week and see if we can land this with full thread visibility 👍
There was a problem hiding this comment.
I think it is needed here because we later explicitly access the ptls.
There was a problem hiding this comment.
Yeah you're absolutely right
|
@topolarity any thoughts about this? Do you think this is good to go as perhaps an intermediate step? It has felt quite useful the times I have tried it out at least. |
|
This looks pretty good IMO. |
KristofferC
force-pushed
the
kc/llvm-opt-zone2
branch
from
ad51e2b
to
ab2a766
Compare
KristofferC
force-pushed
the
kc/llvm-opt-zone2
branch
from
ab2a766
to
4972838
Compare
A random screenshot of usage: