Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in halui docs #2850

Open
hansu opened this issue Jan 17, 2024 · 4 comments
Open

error in halui docs #2850

hansu opened this issue Jan 17, 2024 · 4 comments

Comments

@hansu
Copy link
Member

hansu commented Jan 17, 2024

Reported here: https://forum.linuxcnc.org/32-documents/51387-error-in-halui-docs#290960

I think it would be good to change the pin name in the sources to follow LinuxCNC's convention to use hyphens for that.
To not break the configs we can use the update-ini script to update the config.
What do you think @andypugh ?

@andypugh
Copy link
Collaborator

I agree that we should change the actual pin names and update the update-ini script.
There should also be a mention in the "updating linuxcnc" section of the docs that mentions this.
I further think that it should probably be a 2.10 change rather than go into 2.9.

@hmnijp
Copy link

hmnijp commented Jan 17, 2024

thx for deciding quickly ;)

@hansu
Copy link
Member Author

hansu commented Jan 17, 2024

I further think that it should probably be a 2.10 change rather than go into 2.9.

I also thought in this direction to do this change at least in the next 2.9 release, so 2.9.3. But 2.10 would be also fine.

@andypugh
Copy link
Collaborator

Future 2.9 releases should be bugfixes only (arguably this is a bug fix, but...)
My main reason for preferring to push it to 2.10 is that I don't think that users will be expecting config changes (or to see the update_in script run) after a minor update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants