Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to figure out where the current G43 values are stored. #2566

Open
wants to merge 1 commit into
base: 2.9
Choose a base branch
from

Conversation

petterreinholdtsen
Copy link
Collaborator

No description provided.

@@ -1392,6 +1392,9 @@ G43 <H->

'G43 Hn' uses the offset for tool n.

The active tool length compensation values are stored in the numbered
parameters '5401-5409'.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be no newlines in this hunk, to support translations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoe what is your experience here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be no newlines in this hunk, to support translations.

My view of the matter is that. That translations should not hinder improvement.

@petterreinholdtsen
Copy link
Collaborator Author

petterreinholdtsen commented Jul 5, 2023 via email

@smoe
Copy link
Contributor

smoe commented Aug 5, 2023

I have to paddle back from (a good part of) my past corrections - when the text is at the top level of the document, then po4a and weblate seem to indeed work fine and present this without a newline. Weblate is doing some maintenance at the moment, so I cannot verify [edit - it is sunny over here - it is not yet accepted so I could not check one way or the other]. I suggest to accept as it is and if it fails then Petter is the one to communicate this to the po4a folks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants