Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian build instructions review. #2688

Open
wants to merge 3 commits into
base: 2.9
Choose a base branch
from

Conversation

smoe
Copy link
Contributor

@smoe smoe commented Oct 8, 2023

Tend to think that this improves the clarity of the current set of instructions.

docs/src/code/building-linuxcnc.adoc Outdated Show resolved Hide resolved
docs/src/code/building-linuxcnc.adoc Outdated Show resolved Hide resolved
debian/control.top.in Outdated Show resolved Hide resolved
@smoe smoe force-pushed the debian_nocheck_docs branch 2 times, most recently from 904458d to 92b20a7 Compare October 17, 2023 20:38
Copy link
Collaborator

@petterreinholdtsen petterreinholdtsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few minor issues. The changes seem like a good improvement in general, so I recommend it go in once the minor issues are addressed.

docs/src/code/building-linuxcnc.adoc Outdated Show resolved Hide resolved
docs/src/code/building-linuxcnc.adoc Outdated Show resolved Hide resolved
docs/src/code/building-linuxcnc.adoc Show resolved Hide resolved
docs/src/code/building-linuxcnc.adoc Show resolved Hide resolved
docs/src/code/building-linuxcnc.adoc Outdated Show resolved Hide resolved
== Downloading source tree

The LinuxCNC project git repository is at https://github.com/LinuxCNC/linuxcnc.
GitHub is a popular git hosting service and code sharing website.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to drop the github explanation. Seem out of place and do not really contribute to the explanation on how to download the source.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smoe Do you disagree or just not notice this proposal?

@petterreinholdtsen
Copy link
Collaborator

@smoe Note, @petter is not me. You might want to change the commit message of the last commit do avoid dragging in an innocent third party. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants