-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debian build instructions review. #2688
base: 2.9
Are you sure you want to change the base?
Conversation
904458d
to
92b20a7
Compare
92b20a7
to
0130d17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few minor issues. The changes seem like a good improvement in general, so I recommend it go in once the minor issues are addressed.
== Downloading source tree | ||
|
||
The LinuxCNC project git repository is at https://github.com/LinuxCNC/linuxcnc. | ||
GitHub is a popular git hosting service and code sharing website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to drop the github explanation. Seem out of place and do not really contribute to the explanation on how to download the source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smoe Do you disagree or just not notice this proposal?
a77cadd
to
f525663
Compare
f525663
to
d2976a5
Compare
Tend to think that this improves the clarity of the current set of instructions.