Hostmot2 encoder quad error clear when disabled fix. #2870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change adds a call to hm2_encoder_force_write(hm2) whenever the quad-error-enable is false. In my configurations, I always enable so this extra function call only occurs when the machine is off. I suspect many/most other users don't enable the quad errors so this overhead needs to be evaluated. |
|
Made a mistake combining & operations. |
|
I cannot approve this change as it increases network load significantly (about 10% for a single encoder) , |
|
I have finally been able to duplicate this, it only happens with more than 1 encoder is enabled |
|
Thanks. I'd be happy to assist in testing as I have two computers (7i92,
7i96) and three configs that all exhibit this problem.
…On Tue, Jan 30, 2024 at 7:55 PM pcw-mesa ***@***.***> wrote:
I have finally been able to duplicate this, it only happens with more than
1 encoder is enabled
so I will look at the code when I get a chance.
—
Reply to this email directly, view it on GitHub
<#2870 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHDVLK4BFVNDG5YS2O5OKLYRGQBZAVCNFSM6AAAAABCQDVVQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJYGIZDQMRYHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will reset the quad error when quadrature_error_enable is false. The previous commit fixed the problem for simple halrun scripts, but failed to fix the problem with complete configs running in linuxcnc.