Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HALUI - added pin mdi_is_running #2945

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Conversation

zz912
Copy link
Contributor

@zz912 zz912 commented Mar 23, 2024

I added another HAL pin for halui.

mdi_is_running is TRUE while MDI_COMMAND is running

mdi_is_running exists only if some MDI_COMMAND exists

mdi_is_running can be used for:

  1. GUI developer for disable switching display modes MDI / manual 2) GUI developer for waiting finish
  2. users they need know finish of MDI_COMMANDS

mdi_is_running is not same as status "NOT IDLE"
mdi_is_running is TRUE before activate MDI mode
mdi_is_running is FALSE after leaving MDI mode

halui_mdi_is_running
osciloscop

I added another HAL pin for halui.

mdi_is_running is TRUE while MDI_COMMAND is running

mdi_is_running exists only if some MDI_COMMAND exists

mdi_is_running can be used for:
1) GUI developer for disable switching display modes MDI / manual
2) GUI developer for waiting finish
3) users they need know finish of MDI_COMMANDS

mdi_is_running is not same as status "NOT IDLE"
mdi_is_running is TRUE before activate MDI mode
mdi_is_running is FALSE after leaving MDI mode
@zz912
Copy link
Contributor Author

zz912 commented Mar 24, 2024

I dont know why some checks were not successful. Any idea?
RIP compilation on physical PC was without problems.

@hansu
Copy link
Member

hansu commented Mar 24, 2024

I dont know why some checks were not successful. Any idea? RIP compilation on physical PC was without problems.

Does the test tests/halui/jogging succeeds on your machine?

@zz912
Copy link
Contributor Author

zz912 commented Mar 25, 2024

I dont know why some checks were not successful. Any idea? RIP compilation on physical PC was without problems.

Does the test tests/halui/jogging succeeds on your machine?

No, thank you.

@zz912 zz912 marked this pull request as draft March 29, 2024 12:39
The code made problems in situation: num_mdi_commands = 0
Added waiting after change program_is_idle and mode_is_mdi.
@zz912 zz912 marked this pull request as ready for review March 31, 2024 11:05
@zz912
Copy link
Contributor Author

zz912 commented Mar 31, 2024

  1. Checks are successful:
    The code made problems in situation: num_mdi_commands = 0
    It is fixed now

  2. Added waiting after change program_is_idle and mode_is_mdi.
    halscope-mdi-is-running
    Sleep time in halui component is longer only if mode_is_mdi == 1

@c-morley
Copy link
Collaborator

c-morley commented Apr 2, 2024

'mdi_is_running' - that name implies any mdi command is running.
Is this pin only for halui's mdi commands running?

@zz912
Copy link
Contributor Author

zz912 commented Apr 2, 2024

Is this pin only for halui's mdi commands running?

Yes

If you can think of a better pin name, it's not a problem to change it.

halui_mdi_is_running ?
hal_mdi_is_run ?
halui_mdi_run ?
...

The full name is halui.mdi_is_running

@andypugh
Copy link
Collaborator

andypugh commented Apr 4, 2024

I don't think that this belongs in 2.9 as that it meant to now be bugfixes only.
Can you rebase it on master?
(it's probably neater to cherry-pick it in git rather than try to use the actual rebase command)

@zz912 zz912 changed the base branch from 2.9 to master April 4, 2024 17:59
@zz912 zz912 marked this pull request as draft April 4, 2024 18:32
@zz912
Copy link
Contributor Author

zz912 commented Apr 4, 2024

Checks are not succesfull in master branch. I must fix it.

Fix for master branche.
@zz912
Copy link
Contributor Author

zz912 commented Apr 27, 2024

I would like to ask @c-morley to comment on the naming of the pin. I have no problem changing it, but I need to know what is acceptable.

@c-morley
Copy link
Collaborator

@zz912 I think halui.halui-mdi-is-running (hyphens not underscore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants