-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HALUI - added pin mdi_is_running #2945
base: master
Are you sure you want to change the base?
Conversation
I added another HAL pin for halui. mdi_is_running is TRUE while MDI_COMMAND is running mdi_is_running exists only if some MDI_COMMAND exists mdi_is_running can be used for: 1) GUI developer for disable switching display modes MDI / manual 2) GUI developer for waiting finish 3) users they need know finish of MDI_COMMANDS mdi_is_running is not same as status "NOT IDLE" mdi_is_running is TRUE before activate MDI mode mdi_is_running is FALSE after leaving MDI mode
I dont know why some checks were not successful. Any idea? |
Does the test |
No, thank you. |
The code made problems in situation: num_mdi_commands = 0 Added waiting after change program_is_idle and mode_is_mdi.
'mdi_is_running' - that name implies any mdi command is running. |
Yes If you can think of a better pin name, it's not a problem to change it. halui_mdi_is_running ? The full name is halui.mdi_is_running |
I don't think that this belongs in 2.9 as that it meant to now be bugfixes only. |
Checks are not succesfull in master branch. I must fix it. |
Fix for master branche.
I would like to ask @c-morley to comment on the naming of the pin. I have no problem changing it, but I need to know what is acceptable. |
Added "{"
Added description of halui.mdi-is-running pin.
@zz912 I think halui.halui-mdi-is-running (hyphens not underscore) |
I added another HAL pin for halui.
mdi_is_running is TRUE while MDI_COMMAND is running
mdi_is_running exists only if some MDI_COMMAND exists
mdi_is_running can be used for:
mdi_is_running is not same as status "NOT IDLE"
mdi_is_running is TRUE before activate MDI mode
mdi_is_running is FALSE after leaving MDI mode