Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gmoccapy: update German translation for 2.9 #2946

Open
wants to merge 1 commit into
base: 2.9
Choose a base branch
from

Conversation

hansu
Copy link
Member

@hansu hansu commented Mar 24, 2024

I would like to update the German translations in 2.9.
My plan is to

  1. merge 2.9 into master
  2. merge this PR
  3. merge 2.9 into master with -s ours

This shouldn't cause any merge conflicts in future in master with Weblate, right? @petterreinholdtsen

@petterreinholdtsen
Copy link
Collaborator

I fail to see any update of the 2.9 branch in your recipe. As far as I know, the merge forward process used by LinuxCNC will cause conflicts if PO files are updated in 2.9 and then merged into master.

@hansu
Copy link
Member Author

hansu commented Mar 25, 2024

I fail to see any update of the 2.9 branch in your recipe.

Done with "2. merge this PR" (into 2.9)

As far as I know, the merge forward process used by LinuxCNC will cause conflicts if PO files are updated in 2.9 and then merged into master.

Of course it will cause conflicts, therefore the plan is to resolve them with merge -s ours 2.9

@petterreinholdtsen
Copy link
Collaborator

petterreinholdtsen commented Apr 3, 2024 via email

@hansu
Copy link
Member Author

hansu commented Apr 3, 2024

But why should there appear any merge conflict when merging Weblate's pull request when nothing has changed in master?

@petterreinholdtsen
Copy link
Collaborator

petterreinholdtsen commented Apr 3, 2024 via email

@hansu hansu force-pushed the gmoccapy-de-translation-2.9 branch from 69215e7 to bbff3ff Compare April 3, 2024 18:39
@hansu
Copy link
Member Author

hansu commented Apr 3, 2024

@SebKuzminsky What is your opinion about that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants