Fix some warnings

[moritz-t-w]

Type of change

• Bug fix
• New feature

Description

Just going through the warnings, fixing as much as I can.

Related issues

Mention any issues that this pr relates to.

How Has This Been Tested?

Videos or screenshots of the changes if applicable.

Checklist:

• My code follows the style guidelines of this project.
• I have added comments to my code in more complex areas.
• I have tested the code in both development and production environments.

Progress

Deprecated

• URL constructor -> 665044d: replace with new URI(url).toURL()
• lang3-WordUtils -> 77de6c6: use StringUtils instead
• blocksMovement -> 28589b9: re-implement without using deprecated isSolid()
• NativeImage.makePixelArray(): haven't found any info on alternatives and idk what it does.

Unchecked

• getArgument() a9822ab: suppress the same warnings as method signature

• meteor-client/src/main/java/meteordevelopment/meteorclient/gui/DefaultSettingsWidgetFactory.java

  Line 47 in 8ce8d30

  factories.put(EnumSetting.class, (table, setting) -> enumW(table, (EnumSetting<? extends Enum<?>>) setting));

• meteor-client/src/main/java/meteordevelopment/meteorclient/gui/GuiTheme.java

  Line 121 in ba1cd6e

  values = (T[]) klass.getDeclaredMethod("values").invoke(null);

• meteor-client/src/main/java/meteordevelopment/meteorclient/gui/renderer/GuiRenderOperation.java

  Line 23 in d284194

  pool.free((T) this);

• meteor-client/src/main/java/meteordevelopment/meteorclient/gui/screens/settings/BlockDataSettingScreen.java

  Line 61 in daf6d3f

  T blockData = (T) setting.get().get(block);

• meteor-client/src/main/java/meteordevelopment/meteorclient/gui/screens/settings/BlockDataSettingScreen.java

  Line 71 in daf6d3f

  T blockData = (T) setting.get().get(block);

• meteor-client/src/main/java/meteordevelopment/meteorclient/gui/screens/settings/BlockDataSettingScreen.java

  Line 79 in daf6d3f

  if (data == null) data = (T) setting.defaultData.get().copy();

• meteor-client/src/main/java/meteordevelopment/meteorclient/settings/EnumSetting.java

  Line 24 in daf6d3f

  values = (T[]) defaultValue.getClass().getMethod("values").invoke(null);

• meteor-client/src/main/java/meteordevelopment/meteorclient/settings/Setting.java

  Line 178 in daf6d3f

  return (B) this;

• meteor-client/src/main/java/meteordevelopment/meteorclient/settings/Setting.java

  Line 183 in daf6d3f

  return (B) this;

• meteor-client/src/main/java/meteordevelopment/meteorclient/settings/Setting.java

  Line 188 in daf6d3f

  return (B) this;

• meteor-client/src/main/java/meteordevelopment/meteorclient/settings/Setting.java

  Line 193 in daf6d3f

  return (B) this;

• meteor-client/src/main/java/meteordevelopment/meteorclient/settings/Setting.java

  Line 198 in daf6d3f

  return (B) this;

• meteor-client/src/main/java/meteordevelopment/meteorclient/settings/Setting.java

  Line 203 in daf6d3f

  return (B) this;

• meteor-client/src/main/java/meteordevelopment/meteorclient/settings/Settings.java

  Line 85 in d284194

  RainbowColors.addSetting((Setting<SettingColor>) setting);

• meteor-client/src/main/java/meteordevelopment/meteorclient/settings/Settings.java

  Line 88 in d284194

  RainbowColors.addSettingList((Setting<List<SettingColor>>) setting);

• meteor-client/src/main/java/meteordevelopment/meteorclient/settings/Settings.java

  Line 98 in d284194

  RainbowColors.removeSetting((Setting<SettingColor>) setting);

• meteor-client/src/main/java/meteordevelopment/meteorclient/settings/Settings.java

  Line 101 in d284194

  RainbowColors.removeSettingList((Setting<List<SettingColor>>) setting);

• meteor-client/src/main/java/meteordevelopment/meteorclient/systems/accounts/Account.java

  Line 111 in 1ceea3e

  return (T) this;

• meteor-client/src/main/java/meteordevelopment/meteorclient/systems/modules/player/AutoEat.java

  Line 32 in 6576056

  private static final Class<? extends Module>[] AURAS = new Class[] { KillAura.class, CrystalAura.class, AnchorAura.class, BedAura.class };

• meteor-client/src/main/java/meteordevelopment/meteorclient/systems/modules/player/AutoGap.java

  Line 37 in 6576056

  private static final Class<? extends Module>[] AURAS = new Class[] { KillAura.class, CrystalAura.class, AnchorAura.class, BedAura.class };

• meteor-client/src/main/java/meteordevelopment/meteorclient/utils/misc/UnorderedArrayList.java

  Line 22 in d284194

  items = (T[]) DEFAULTCAPACITY_EMPTY_ELEMENTDATA;

• meteor-client/src/main/java/meteordevelopment/meteorclient/utils/render/WireframeEntityRenderer.java

  Line 62 in b0d1686

  EntityModel<LivingEntity> model = renderer.getModel();

Resource Leak

• BeaconScreenMixin getInstance() -> 1ae70cd: declare variable
• BlockCollisionSpliteratorMixin getInstance() -> 1ae70cd: declare variable
• BlockItemMixin getWorld() -> 1ae70cd: declare variable
• PlayerEntityMixin:56 getWorld() -> 1ae70cd: declare variable
• PlayerEntityMixin:63 getWorld() -> 1ae70cd: declare variable
• PlayerEntityMixin:84 getWorld() -> 1ae70cd: declare variable
• PlayerEntityMixin:92 getWorld() -> 1ae70cd: declare variable
• PlayerEntityMixin:107 getWorld() -> 1ae70cd: declare variable
• ChunkAwareBlockCollisionSweeperMixin getInstances() -> 1ae70cd: declare variable
• Utils readBytes() -> 1ae70cd: close stream

Unused Import

• BaritoneUtils
• BaritoneAPI
• FlowableFluid
• MatrixStack
• Perspective
• TextRenderer
• BufferBuilder
• VertexConsumerProvider
• RenderUtils
• Rotation
• TextRenderer
• BufferBuilder
• VertexConsumerProvider
• AbstractTeam
• AuthenticationException

Unused Variable/Field

• EasyMCAccount.AuthResponse.message should remain, for completeness
• Hud.keybind* -> 1448187
• local var item -> 2fcaed3
• Blink.cancelBlink* -> 1448187
• ElytraBoost.keybind* -> 1448187
• LightOverlay.bp -> c2231b3: suppress
• CuboidMarker.mode -> 1448187
• Sphere2dMarker.nextLayerKey -> 1448187
• Sphere2dMarker.prevLayerKey -> 1448187
• local var layer -> 2fcaed3

* Used, but in a hacky way

[Big-Iron-Cheems]

To be brief:

• All of the null warnings are not actually triggerable at the moment the code is called.
• The stream related warnings about missing close calls should be handled via try-with-resources.

[moritz-t-w]

All of the null warnings are not actually triggerable at the moment the code is called.

Yeah I just kinda added the null warnings and I was gonna see what's actually necesary.

The stream related warnings about missing close calls should be handled via try-with-resources.

The only one that I used .close() had another stream closed that way in the same method, so I did the same. The others I thought making a variable out of them should take care of it, but if not, I'll look into that.

[moritz-t-w]

There's a few unused fields that are keybinds, what's up with that?

[Big-Iron-Cheems]

There's a few unused fields that are keybinds, what's up with that?

If you're referring to the HUD keybind, it is actually used, but in a hacky way.
HUD is not an implementation of the Module class, but it still requires a Keybind for it to be rendered and used.