Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FakePlayer Rewrite #4283

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

CrytoPal
Copy link
Contributor

@CrytoPal CrytoPal commented Dec 16, 2023

Type of change

  • Bug fix
  • New feature

Description

Lets the Fake Player take Damage and pop Totems. It also lets you play movement Recordings.

Related issues

none

How Has This Been Tested?

Trial and Error, Works with multiple Fake Player Entities as well.

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@CrytoPal CrytoPal changed the title FakePlayer Damage FakePlayer Rewrite Dec 17, 2023
@Wide-Cat
Copy link
Collaborator

I'm not sure about all these changes. When the damage setting is disabled you can still hit the entity and it simulates taking damage, just without a totem, which it wasn't like before. The movement recording thing seems really finicky; it isn't clear when it's recording and when it isn't, and it's pretty easy to completely break it if you start recording and playing at the same time with loop recording enabled.

@Wide-Cat
Copy link
Collaborator

I think this just needs a lot more polish. When it works it's pretty good but it just feels like this was committed before it's actually done.

Notifies you on the current status for Recording and Playing. Fixes fake-player taking damage even though the Allow Damage setting was disabled. Fixes a little bit of the weird leg movement for the recording. Fixes a bug where you could record and play at the same time.
@CrytoPal
Copy link
Contributor Author

@Wide-Cat I fixed the bugs you mentioned.

@tympanicblock61
Copy link
Contributor

you could add a setting to allow them to be in network player list

@tympanicblock61
Copy link
Contributor

you could add a way to send a message from one of the fake players

@tympanicblock61
Copy link
Contributor

you could instead of having the settings global have them for each fakeplayer (this is just a suggestion dont really think you will add it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants