Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendChatMessage event fix (Better Chat fix) #4489

Merged
merged 3 commits into from
May 8, 2024

Conversation

FurnyGo
Copy link
Contributor

@FurnyGo FurnyGo commented Mar 29, 2024

Type of change

  • Bug fix

Description

Fix sendChatMessage event baritone check

Related issues

#4377

How Has This Been Tested?

Don't install baritone, run meteor and enable better chat prefix/suffix/fancy text function

Checklist:

  • I have tested the code in both development and production environments.

@FurnyGo FurnyGo changed the title sendChatMessage event fix sendChatMessage event fix (Better Chat fix) Mar 29, 2024
@FurnyGo
Copy link
Contributor Author

FurnyGo commented May 7, 2024

@Wide-Cat can you check? This is literally 4 chars change in code

@Wide-Cat
Copy link
Collaborator

Wide-Cat commented May 7, 2024

I'll test it this evening, but the boolean logic still doesn't look right to me. It's supposed to send the event if the message doesnt start with meteors prefix, and baritone is not available or it doesn't start with baritones prefix, right?

@Wide-Cat
Copy link
Collaborator

Wide-Cat commented May 7, 2024

this doesnt work btw you cant use any of meteors commands anymore

@FurnyGo
Copy link
Contributor Author

FurnyGo commented May 7, 2024

It's supposed to send the event if the message doesnt start with meteors prefix, and baritone is not available or it doesn't start with baritones prefix, right?

It looked like this before the changes
If you change "or" to "and" everything works fine

@Wide-Cat
Copy link
Collaborator

Wide-Cat commented May 7, 2024

Ok now it will only send the event if baritone is installed. Literally just read through the if statement in your head and see if it makes sense or not.

@FurnyGo
Copy link
Contributor Author

FurnyGo commented May 7, 2024

I hope everything works fine now

@Wide-Cat Wide-Cat merged commit 142cf9a into MeteorDevelopment:master May 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants