port .nbt to 1.20.5+ #4574
Open
port .nbt to 1.20.5+ #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wide-Cat
requested changes
May 28, 2024
There was a problem hiding this comment.
Suggestions for the remove subcommand seem slightly broken, presumably because it doesn't a system provided by mojang. You need to specify the minecraft: prefix for most of them which is inconvenient, but if you put 's', 'r' or 'c' it suggests one component for some reason.
Working as desired:
Broken:
???:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
make .nbt support data components
How Has This Been Tested?
it was very fun to play around with
Checklist: