Ben/mv5/anchor #3029
Open
Ben/mv5/anchor #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String locationString = anchorsSection.getString(key, ""); | ||
| Location anchorLocation = this.locationManipulation.stringToLocation(locationString); | ||
| if (anchorLocation == null) { | ||
| Logging.warning("The location for anchor '%s' is INVALID.", key); |
There was a problem hiding this comment.
The docs indicate that the Try will be successful if all anchors or loaded. However, this looks like a case where an anchor isn't loaded. Is it worth handling this differently?
| * | ||
| * @param anchorName The name of the anchor. | ||
| * @param locationString The location of the anchor as string. | ||
| * @return Empty {@link Try} if all anchors were successfully loaded, or the exception if an error occurred. |
| @@ -144,46 +144,61 @@ | |||
|
|
|||
| /** | |||
| * Gets all anchors that the specified {@link Player} can access. | |||
| * @param p The {@link Player}. | |||
| * | |||
| * @param player The {@link Player}. | |||
| * @return An unmodifiable {@link Set} containing all anchors the specified {@link Player} can access. | |||
There was a problem hiding this comment.
Your changes do not return an unmodifiable set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to fix variable naming, use vavr, fix checkstyle etc... Also added relevant commands to set, list and delete anchors.