Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /mv spawn tp and /mv spawn set #3057

Draft
wants to merge 5 commits into
base: MV5
Choose a base branch
from
Draft

Add /mv spawn tp and /mv spawn set #3057

wants to merge 5 commits into from

Conversation

zax71
Copy link
Member

@zax71 zax71 commented Feb 24, 2024 •
edited

Renamed /mvspawn to /mv spawn tp and /mvsetspawn to /mv spawn set

@zax71 zax71 added 5.0.0 Next major release. no release labels Feb 24, 2024
@zax71 zax71 mentioned this pull request Feb 24, 2024
Draft
75 tasks
@zax71 zax71 marked this pull request as draft February 24, 2024 18:20
@zax71 zax71 changed the title Add /mv spawn Add /mv spawn tp and /mv spawn set Feb 24, 2024
benwoo1110
benwoo1110 reviewed Mar 8, 2024
View reviewed changes
Copy link
Member

@benwoo1110 benwoo1110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think dont need to change the command format. /mv spawn should be teleport to the world's spawn. Then i think /mv setspawn is fine? dont need to change to /mv spawn set

src/main/java/org/mvplugins/multiverse/core/commands/SpawnCommand.java
LoadedMultiverseWorld world = worldManager.getLoadedWorld(player.getWorld().getName()).getOrNull();

// Teleport the player
safetyTeleporter.teleportSafely(issuer.getIssuer(), player, world.getSpawnLocation());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to check if teleport fails

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I go about doing this? Using .toAttempt().onFailiure() causes the server to crash

src/main/java/org/mvplugins/multiverse/core/commands/SpawnCommand.java Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwoo1110 benwoo1110 benwoo1110 left review comments

@dumptruckman dumptruckman Awaiting requested review from dumptruckman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
5.0.0 Next major release. no release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zax71 @benwoo1110