Control over Nav Rows #547
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 26, 2013 11:04
… a minute or two, like a sports event or a malware attack sequence
… a Thu Dec 26 11:46:19 IST 2013 section puts this event in an annotated swimlane. however the swimlanes are arranged according to first-come. Adding a tags list (optional) allows to control the vertical arrangments of these lanes
1. Fixed recursive merging of config object, allows setting properties under config.nav and below 2. Remove hard coded calculations of row size and count 3. Added support for pre-ordered rows via node in JSON
|
+1 for merge |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added control over the number of rows, size, and how they are ordered. This helps build cases where you need to break events into more than 3 full / 6 half sized rows - which is currently hard coded. Here is a short summary of the changes:
config.navand belowtagsnode in JSONsecondsas intervals - one of my use cases was a sequence that lasts only 2 minutes*** IMPORTANT ***- I did not create a minified build as thefab buildcommand does not work for me - I also opened an issue #546 for that. If you merge this branch you will also need to create a build (or better yet help my issue and command me to do it ;)Hope you find this useful
Ron