Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "nothing?callback=onJSONP_Data" 404 (Not Found) error #814

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gotjoshua
Copy link

When trying to update recline and timemapper to the most recent TimelineJS, i was getting a 404 (Not Found) error relating to a final getJSON call to "nothing?callback=onJSONP_Data"
Investigation showed that the data was already received, but not being added to the config.source, which resulted in a call to "nothing" the default source on the config object.

additionally I changed to the ajax call rather than getJSON based on the advice of the article that I cited in the comment:
http://stackoverflow.com/questions/1002367/jquery-ajax-jsonp-ignores-a-timeout-and-doesnt-fire-the-error-event

This seemed to work inside timemapper, but broke the timelineJS test:
http://recline.1zm.in/vendor/TimelineJS2/tests/test_extra_html.html

So i rolled it back to still use getJSON... I left the comment in there to start a discussion... what are the advantages of getJSON? do you agree in general with the advice from Husky on that stackoverflow link?

cheers,
gotjoshua

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant