Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom icons as "tl-timemarker-content-container" #844

Open
dasrecord opened this issue Dec 12, 2023 · 1 comment
Open

Use custom icons as "tl-timemarker-content-container" #844

dasrecord opened this issue Dec 12, 2023 · 1 comment

Comments

@dasrecord
Copy link

dasrecord commented Dec 12, 2023

Deploying career timelines for each artist on a music agency website.
GitHub for project available here.

Main feedback from is that the vertical sizing/spacing of the timeline bar and event cards are too large in the X axis.
Furthermore, one of our artists asked if it was possible to replace the cards with a small icon instead.

Would love to contribute to this amazing tool.

@JoeGermuska
Copy link
Member

In case you didn't realize, you can use the "media thumbnail" for a slide (column O in the spreadsheet, or in .events[].media.thumbnail in the JSON config -- in either case the value should be a URL that resolves to an image.
https://timeline.knightlab.com/docs/using-spreadsheets.html
https://timeline.knightlab.com/docs/json-format.html

This doesn't address the vertical sizing/spacing part. We readily admit that TimelineJS isn't well factored for custom CSS, since the logic and presentation are fairly entangled, and the CSS selectors tend to be overly specific, but see https://timeline.knightlab.com/docs/overriding-styles.html for a little more on that.

We tend to be conservative about accepting changes to the codebase, so if the effort you'd spend changing the code is contingent on whether it's merged into this repo, we should talk about it before you do all the work -- but if making it work is more important than whether it gets merged, go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants