Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NuGet.org Bug]: Search parameter tfms=net lights up the .NET framework generation checkbox #9846

Open
advay26 opened this issue Mar 6, 2024 · 0 comments

Comments

@advay26
Copy link
Contributor

advay26 commented Mar 6, 2024

Impact

It bothers me. A fix would be nice

Describe the bug

When you search on nuget.org using the tfms=net parameter, the .NET framework checkbox is shown as selected. This should not be selected.

The .NET framework generation checkbox should only be selected if frameworks=net is in the URL. tfms=net refers to the version-less '.NET Framework' (not '.NET') TFM, not a framework generation.

Repro Steps

  1. Go to https://www.nuget.org/packages?q=&tfms=net
  2. The .NET framework generation checkbox is selected in the filter panel, even though there is no frameworks=net parameter.

Expected Behavior

None of the checkboxes should be selected in this case.

tfms=net refers to the version-less .NET Framework TFM (shortname = 'net'), not the .NET 5+ framework generation. The js code in https://github.com/NuGet/NuGetGallery/blob/main/src/NuGetGallery/Scripts/gallery/page-list-packages.js#L177 does not distinguish between frameworks= and tfms= parameters properly, and needs to be fixed.

Screenshots

No response

Additional Context and logs

No response

@advay26 advay26 added this to the Sprint 2024-04 milestone Mar 6, 2024
@advay26 advay26 self-assigned this Mar 6, 2024
@advay26 advay26 modified the milestones: Sprint 2024-04, Sprint 2024-05 Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants