Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Could you please add "www.infragistics.com" to allowed domains list for images? #9910

Open
jsakamotoIGJP opened this issue Apr 9, 2024 · 6 comments

Comments

@jsakamotoIGJP
Copy link
Contributor

Related Problem

We want to use images in our product NuGet packages' readme, but the URLs of those images are under the "www.infragistics.com" domain (ex. https://www.infragistics.com/products/ignite-ui-blazor/blazor/images/general/getting-started-blazor-card.jpg). Unfortunately, "www.infragistics.com" is not listed in the allowed domains list of nuget.org, so we can't use those images in our NuGet package readme.

The Elevator Pitch

You said "please feel free to file an issue", so we send this request. Thanks in advance.

Additional Context and Details

No response

@jsakamotoIGJP jsakamotoIGJP added the feature-request Customer feature request label Apr 9, 2024
@erdembayar
Copy link
Contributor

@lyndaidaii
Could you please provide the link to the process?

@jsakamotoIGJP
Please look at previous example for it: #9857

@erdembayar erdembayar added Area: Support and removed feature-request Customer feature request labels Apr 9, 2024
@lyndaidaii
Copy link
Contributor

@jsakamotoIGJP , thank you for providing feedback. Is there any package you own on NuGet.org have readme with www.infragistics.com with images? Currently, we didn't see any customer include image with www.infragistics.com domain. Please let us know about the intention, thanks.

@jsakamotoIGJP
Copy link
Contributor Author

Hi @lyndaidaii,
Thank you for your prompt response!

We have not yet included images whose URL is under the "www.infragistics.com" domain in a README of our published NuGet packages. One of our published NuGet packages is in the following URL.

We will update our published NuGet packages soon to include a README with images under that domain, so I requested this feature. I have attached the README document file, which we will include in our NuGet packages.

🗒️README_Trial_Blazor.md

I hope that this reply is helpful for the reviewing process.

@jsakamotoIGJP
Copy link
Contributor Author

@lyndaidaii any updates? thanks!

@lyndaidaii
Copy link
Contributor

Thanks for providing details. The domain looks fine to include. Feel free to create the PR to include this domain.
Add domain into this json file.
https://github.com/NuGet/NuGetGallery/blob/main/src/NuGetGallery/App_Data/Files/Content/Trusted-Image-Domains.json

Thanks, please let us know if you have any other question.

@jsakamotoIGJP
Copy link
Contributor Author

Thanks, @lyndaidaii, I sent a pull request, #9947.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants