Support username casing change in Admin UI #9748

RiadGahlouz · 2023-12-08T23:09:20Z

Summary of the changes (in less than 80 characters):
This PR adds support for username casing change in the Admin UI. There are no UI changes, simply controller flow changes.

Addresses https://github.com/NuGet/Engineering/issues/5057

src/NuGetGallery/Areas/Admin/Controllers/ChangeUsernameController.cs

advay26 · 2023-12-09T00:18:02Z

Should this be the linked issue? https://github.com/NuGet/Engineering/issues/5057

dannyjdev

Apart from updating the record, there is a previous step we perform when changing username casing. We check if the user have available packages (check the playbook for more context). I think this could be added by adding a column on the first form (Verify Account) to include if the user has available packages. And also, please update the playbook with this new changes.

src/NuGetGallery/Areas/Admin/Controllers/ChangeUsernameController.cs

Add checkbox to check owned packages

Add new param to ValidateNewUsername endpoint

erdembayar · 2024-01-10T01:07:05Z

src/NuGetGallery/Areas/Admin/Controllers/ChangeUsernameController.cs

@@ -83,14 +87,28 @@ public ActionResult VerifyAccount(string accountEmailOrUsername)
        }

        [HttpGet]
-        public ActionResult ValidateNewUsername(string newUsername)
+        public ActionResult ValidateNewUsername(string newUsername, bool checkOwnedPackages, string oldUsername = "")


I don't see where we're passing true for checkOwnedPackages other than unit test. How we're passing value here?

@RiadGahlouz
Have you looked into my question? After this I can approve this PR.

It's coming from a form input:

NuGetGallery/src/NuGetGallery/Areas/Admin/Views/ChangeUsername/Index.cshtml

Line 62 in 44b0ccf

<input type="checkbox" id="checkNonDeletedOwnedPackages" data-bind="checked: checkOwnedPackages" />

agr · 2024-01-23T23:58:40Z

src/NuGetGallery/Areas/Admin/Views/ChangeUsername/Index.cshtml

        <input type="text" placeholder="New username" autocomplete="off" autofocus style="width: 200px;" rows="1" data-bind="value: newUsername" />
+        <input type="checkbox" id="checkNonDeletedOwnedPackages" data-bind="checked: checkOwnedPackages" />
+        <label for="checkNonDeletedOwnedPackages">Check Non-Deleted Owned Packages</label>


If setting this checkbox just adds a list of owned packages, how about changing it to "List ..."?

Maybe even enable it automatically if new/old only differs by the case?

lyndaidaii · 2024-01-24T00:19:10Z

src/NuGetGallery/Areas/Admin/Controllers/ChangeUsernameController.cs

+            return new ValidateUsernameResult()
+            {
+                IsFormatValid = UsernameValidationRegex.IsMatch(username),
+                IsAvailable = foundUser == null || (requestor.Key == foundUser.Key && foundUser.Username != username) // The username check is in the event where we found a user in the DB but we're doing a cAsIng change


Suggested change

IsAvailable = foundUser == null || (requestor.Key == foundUser.Key && foundUser.Username != username) // The username check is in the event where we found a user in the DB but we're doing a cAsIng change

IsAvailable = foundUser == null || (requestor.Key == foundUser.Key && foundUser.Username != username) // The username check is in the event where we found a user in the DB but we're doing a casing change

zhhyu · 2024-01-24T19:29:06Z

tests/NuGetGallery.Facts/Areas/Admin/Controllers/ChangeUsernameControllerFacts.cs

+            {
+                var oldUsername = IndividualAccount.Username;
+
+                var result = await ChangeUsernameController.ChangeUsername(IndividualAccount.Username, IndividualAccount.Username.ToUpper()) as JsonResult;


IndividualAccount.Username

nit: "IndividualAccount.Username" -> "oldUsername"

zhhyu · 2024-01-24T20:17:49Z

src/NuGetGallery/Areas/Admin/Controllers/ChangeUsernameController.cs

@@ -83,14 +87,28 @@ public ActionResult VerifyAccount(string accountEmailOrUsername)
        }

        [HttpGet]
-        public ActionResult ValidateNewUsername(string newUsername)
+        public ActionResult ValidateNewUsername(string newUsername, bool checkOwnedPackages, string oldUsername = "")


= ""

I am thinking whether this default value is needed, if this "oldUsername" will be passed to query DB anyway. Should the caller always pass an "oldUsername"? The API shape is changed here, so I guess that the PR updates all the callers who use this API.

zhhyu · 2024-01-24T20:20:48Z

src/NuGetGallery/Areas/Admin/Controllers/ChangeUsernameController.cs

        {
            if (string.IsNullOrEmpty(newUsername))
            {
                return Json(HttpStatusCode.BadRequest, "Username cannot be null or empty.", JsonRequestBehavior.AllowGet);
            }

-            var result = ValidateUsername(newUsername);
+            var oldAccount = _userService.FindByUsername(oldUsername);


oldAccount

nit: oldAccount -> account

It may be better to use the same name for local variables under the same class. For example, line 130 uses "account". We can follow the same name convention and also the account itself is still the same but the name will be changed. Personally I think this is more readable and easier to maintain in the future.

zhhyu · 2024-01-24T20:26:05Z

src/NuGetGallery/Areas/Admin/Controllers/ChangeUsernameController.cs

@@ -116,39 +134,44 @@ public async Task<ActionResult> ChangeUsername(string oldUsername, string newUse
                return Json(HttpStatusCode.NotFound, "Old username account was not found.", JsonRequestBehavior.AllowGet);
            }

-            var newUsernameValidation = ValidateUsername(newUsername);
+            var newUsernameValidation = ValidateUsernameChange(account, newUsername);


newUsernameValidation

nit: newUsernameValidation -> validatedResult

The same at line 103.

erdembayar · 2024-05-22T23:03:06Z

@RiadGahlouz
I changed to draft mode since there has been no update in the past few months and there few comments not addressed. Feel free to switch to Ready to review mode when the PR is ready.

RiadGahlouz added 2 commits December 8, 2023 15:06

Change controller flow to support casing update

f9ccefc

Remove unnecessary import

edd8110

RiadGahlouz self-assigned this Dec 8, 2023

RiadGahlouz requested a review from a team as a code owner December 8, 2023 23:09

lyndaidaii previously approved these changes Dec 8, 2023

View reviewed changes

mariaghiondea reviewed Dec 8, 2023

View reviewed changes

src/NuGetGallery/Areas/Admin/Controllers/ChangeUsernameController.cs Show resolved Hide resolved

mariaghiondea previously approved these changes Dec 8, 2023

View reviewed changes

erdembayar previously approved these changes Dec 8, 2023

View reviewed changes

advay26 previously approved these changes Dec 9, 2023

View reviewed changes

Move audit to after username change

0158a73

RiadGahlouz dismissed stale reviews from advay26, erdembayar, mariaghiondea, and lyndaidaii via 0158a73 December 9, 2023 00:30

mariaghiondea previously approved these changes Dec 11, 2023

View reviewed changes

dannyjdev reviewed Dec 11, 2023

View reviewed changes

zhhyu reviewed Dec 11, 2023

View reviewed changes

src/NuGetGallery/Areas/Admin/Controllers/ChangeUsernameController.cs Show resolved Hide resolved

zhhyu reviewed Dec 11, 2023

View reviewed changes

src/NuGetGallery/Areas/Admin/Controllers/ChangeUsernameController.cs Outdated Show resolved Hide resolved

RiadGahlouz and others added 4 commits December 11, 2023 16:11

Updading username change check to include identity check

69aa0b3

Update Index.cshtml

0976baa

Add checkbox to check owned packages

Update ChangeUsernameController.cs

84e2929

Add new param to ValidateNewUsername endpoint

Added check for owned packages and some tests

fb21e0e

RiadGahlouz dismissed mariaghiondea’s stale review via fb21e0e January 3, 2024 21:14

erdembayar reviewed Jan 10, 2024

View reviewed changes

Remove old code

44b0ccf

agr reviewed Jan 23, 2024

View reviewed changes

lyndaidaii reviewed Jan 24, 2024

View reviewed changes

zhhyu reviewed Jan 24, 2024

View reviewed changes

RiadGahlouz added 3 commits February 8, 2024 12:09

Merge validate & change

c20bc34

Delete commented code

5b184eb

Fix tests

29a6035

erdembayar marked this pull request as draft May 22, 2024 23:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support username casing change in Admin UI #9748

Support username casing change in Admin UI #9748

RiadGahlouz commented Dec 8, 2023 •

edited

advay26 commented Dec 9, 2023

dannyjdev left a comment

erdembayar Jan 10, 2024

erdembayar Jan 23, 2024

agr Jan 25, 2024

agr Jan 23, 2024

agr Jan 24, 2024

lyndaidaii Jan 24, 2024

zhhyu Jan 24, 2024

zhhyu Jan 24, 2024

zhhyu Jan 24, 2024 •

edited

zhhyu Jan 24, 2024

erdembayar commented May 22, 2024 •

edited

	IsAvailable = foundUser == null \|\| (requestor.Key == foundUser.Key && foundUser.Username != username) // The username check is in the event where we found a user in the DB but we're doing a cAsIng change
	IsAvailable = foundUser == null \|\| (requestor.Key == foundUser.Key && foundUser.Username != username) // The username check is in the event where we found a user in the DB but we're doing a casing change

Support username casing change in Admin UI #9748

Are you sure you want to change the base?

Support username casing change in Admin UI #9748

Conversation

RiadGahlouz commented Dec 8, 2023 • edited

advay26 commented Dec 9, 2023

dannyjdev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhhyu Jan 24, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

erdembayar commented May 22, 2024 • edited

RiadGahlouz commented Dec 8, 2023 •

edited

zhhyu Jan 24, 2024 •

edited

erdembayar commented May 22, 2024 •

edited