DEV9: More strictly enforce MTU in pcap #11247
Open
+96
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLastRar
force-pushed
the
DEV9-pcap-mtu
branch
3 times, most recently
from
0f29f86
to
01b4ee0
Compare
|
Added code to account for the Ethernet frame sequence check. |
TheLastRar
force-pushed
the
DEV9-pcap-mtu
branch
3 times, most recently
from
97aff5a
to
14c23cb
Compare
We should be able to get the MAC address on all supported platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
More strictly enforce MTU of packets received using pcap
Rationale behind Changes
The previous limit was not strict enough, allowing 'small' jumbo frames to be received.
This was causing TLB misses and other issues in some homebrew software, due to what appeared to be a buffer overrun.
Suggested Testing Steps
Test pcap backend on network games and homebrew (that receive large packets).
Testing should be performed in a network that supports an MTU > 1500
Testing in networks that have an MTU == 1500 would be useful to ensure we aren't too strict.
I currently assume that libpcap dosn't capture the etherframe FCSThis might not be the case on FreeBSD or MacOSX, as libpcap, so specific testing there would needed.