DEV9: Adapter Utils Cleanup #11271
Merged
DEV9: Adapter Utils Cleanup #11271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLastRar
force-pushed
the
DEV9-AdapterUtilsCleanup
branch
2 times, most recently
from
dbdde84
to
1f7406b
Compare
Returned data is not sequenced IP_ADAPTER_ADDRESSES entries We will use implicit object creation avoid UB
This attempts to avoid undefined behaviour with our current assumptions about the socket api
Giving same flow as Windows code
TheLastRar
force-pushed
the
DEV9-AdapterUtilsCleanup
branch
2 times, most recently
from
9ac24c1
to
bf60855
Compare
TheLastRar
force-pushed
the
DEV9-AdapterUtilsCleanup
branch
from
bf60855
to
b3b8c8e
Compare
|
Tested for Sockets on Appimage for linux, seems to work fine!
Emulog for reference: |
Mrlinkwii
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Merge code related to getting a network adapter.
Corrected the buffer type used for
GetAdaptersAddresses(), as other structures where also placed in there.Replace C-Style casts with C++ equivalents.
It may be easier to review each commit one by one rather than the whole pr at once
Rationale behind Changes
This effort was mostly born this #10937 (comment), regarding type punning
The socket api does not make it easy to avoid UB type punning, due to strict aliasing rules, The general consensus appears to be that these types are passed in an aliased form and we just cast back to get the true type.
Suggested Testing Steps
Test connection with pcap. sockets and tap
Test the above (where supported) on Windows, Linux and FreeBSD/Mac