Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS/HW: Add ROV based blending/colclip/fbmask/afail for DX11/DX12 #7655

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stenzek
Copy link
Member

@stenzek stenzek commented Dec 22, 2022

Description of Changes

Not ready for widespread use, here for testing.

  • Make dx11/dx12 not break if the gpu doesn't support rov
  • Port across to vulkan renderer with fragment shader interlock
  • Optimization and address all the TODOs I left in comments

Rationale behind Changes

ROV can be pretty fast in some games. Plus AFAIL handling isn't double pass.

Suggested Testing Steps

None yet.

Fixes Hot Shots FORE Golf/Everybody's Golf menus, Fixes #1499 Fixes #3876 Fixes #3350

@JordanTheToaster
Copy link
Contributor

Fixes the shadows part of #6839

image

@refractionpcsx2
Copy link
Member

refractionpcsx2 commented Dec 22, 2022

Makes Hot Shots Golf worse, I think the condition/problem has actually been inverted, as you can see from the screenshot, the "blotches" which shouldn't be there, are all that's there lol

DX12:
image

Vulkan:
image

SW:
image

Dump:
Hot Shots Golf FORE! ate depth.zip

@refractionpcsx2
Copy link
Member

refractionpcsx2 commented Dec 22, 2022

This problem from The Suffering was said to be an Alpha test/Depth problem but I can't remember the condition to what's happening, but for prosperity that doesn't work either

DX12:
image

SW:
image

Dump:
SufferingATE.zip

@refractionpcsx2
Copy link
Member

Slight update, I need to do "Maximum" blending to get Hot shots to work, and it is fixed like that

image

@GitHub-Khi
Copy link

Slight update, I need to do "Maximum" blending to get Hot shots to work, and it is fixed like that

image

Can you please check the PAL version of Hot Shots Golf Fore! as well?

Single Frame GS-Dump:
Everybody's Golf_SCES-52582_20221222213239.zip

@refractionpcsx2
Copy link
Member

image

@DonelBueno
Copy link

DonelBueno commented Jan 16, 2023

This is huge for games like SSX and Black, which need Full blending for proper emulation in HW.

On Vulkan, the fastest renderer for both games in master, SSX goes from 46 to 64 fps (6x native) and Black from 51 to 91 fps (6x native).

@lightningterror
Copy link
Contributor

DX12 crashes with sharpening enabled (non rov gpu), also noticed this in the logs.
[ 46.0960] C:\GitHub\master-pcsx2\pcsx2\bin\0(248,32): warning X4000: use of potentially uninitialized variable (FxaaPixelShader)

@Uzarkis
Copy link

Uzarkis commented Oct 25, 2023

@stenzek - Do you need more tests with the golf games?

@stenzek
Copy link
Member Author

stenzek commented Oct 25, 2023

No, and please stop posting/bumping PRs.

@bigol83
Copy link

bigol83 commented May 12, 2024

With the latest commits there is a big improvement to some graphics issues i noticed in MGS3 but there are still some kind of random red flashes with DX11. DX12 and every other renderer is good.

Metal Gear Solid 3 - Snake Eater_SLES-82024_20240512044023.gs.zip

@stenzek
Copy link
Member Author

stenzek commented May 12, 2024

Not really concerned about DX11, I'll probably drop the ROV path for DX11 prior to merging. It's much slower than DX12.

@seta-san
Copy link
Contributor

Come to think about it. Why is dx11 still supported? Didn’t windows 10 ship with dx12?

@JordanTheToaster
Copy link
Contributor

Come to think about it. Why is dx11 still supported? Didn’t windows 10 ship with dx12?

Because not everyone has a new enough card to use Vulkan so they have to use DX11 such as every Intel iGPU pre Xe Nvidia Fermi and Kepler and AMD GCN 3 and older.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment