-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GS/HW: Add ROV based blending/colclip/fbmask/afail for DX11/DX12 #7655
base: master
Are you sure you want to change the base?
Conversation
Fixes the shadows part of #6839 |
Makes Hot Shots Golf worse, I think the condition/problem has actually been inverted, as you can see from the screenshot, the "blotches" which shouldn't be there, are all that's there lol |
This problem from The Suffering was said to be an Alpha test/Depth problem but I can't remember the condition to what's happening, but for prosperity that doesn't work either Dump: |
Can you please check the PAL version of Hot Shots Golf Fore! as well? Single Frame GS-Dump: |
This is huge for games like SSX and Black, which need Full blending for proper emulation in HW. On Vulkan, the fastest renderer for both games in master, SSX goes from 46 to 64 fps (6x native) and Black from 51 to 91 fps (6x native). |
111e228
to
6918840
Compare
DX12 crashes with sharpening enabled (non rov gpu), also noticed this in the logs. |
994e62d
to
284e887
Compare
f21aefa
to
8f8290e
Compare
@stenzek - Do you need more tests with the golf games? |
No, and please stop posting/bumping PRs. |
7d4a010
to
f10f3e0
Compare
96e78ec
to
33cabff
Compare
With the latest commits there is a big improvement to some graphics issues i noticed in MGS3 but there are still some kind of random red flashes with DX11. DX12 and every other renderer is good. Metal Gear Solid 3 - Snake Eater_SLES-82024_20240512044023.gs.zip |
Not really concerned about DX11, I'll probably drop the ROV path for DX11 prior to merging. It's much slower than DX12. |
Come to think about it. Why is dx11 still supported? Didn’t windows 10 ship with dx12? |
Because not everyone has a new enough card to use Vulkan so they have to use DX11 such as every Intel iGPU pre Xe Nvidia Fermi and Kepler and AMD GCN 3 and older. |
Description of Changes
Not ready for widespread use, here for testing.
Rationale behind Changes
ROV can be pretty fast in some games. Plus AFAIL handling isn't double pass.
Suggested Testing Steps
None yet.
Fixes Hot Shots FORE Golf/Everybody's Golf menus, Fixes #1499 Fixes #3876 Fixes #3350