Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a Portrait with a Background Image ignores background size & placement #86

Open
melek opened this issue May 8, 2020 · 2 comments

Comments

@melek
Copy link

melek commented May 8, 2020

Describe the bug
When exporting a Portrait with a background image, the background image sizing and placement on the TokenTool canvas is ignored in the output, making bars of the current background color (or black if transparent). The background image is instead pushed to the top left of the background of the token image.

To Reproduce
Steps to reproduce the behavior:

  1. In TokenTool 2.1 add a partially transparent portrait image and a background image of a different size.
  2. Scale and pan the background image to contain the whole token. You can choose a bright background color as well to help illustrate the error.
  3. In 'Save Options' accordion panel, check 'Save Portrait on Drag & Drop' and 'Use Background Options'
  4. Drag the token into MapTool or the file system.
  5. See error, the background image is in a default location behind the portrait, rather than scaled/panned as in TT

Expected behavior
That the background layer is scaled/panned in the Portrait export the same as I placed it on the TT canvas.

Screenshots
TokenTool, note the background extends to contain the whole token:
image

After Export, note the yellow bars and background size/placement:
image

TokenTool Info

  • Version: 2.1
  • Install: New

Desktop (please complete the following information):

  • OS: Windows 10

Additional context
This is probably a non-issue for most people so maybe a low priority, though with Heroforge's new coloring tools I'll be using the backgrounds in TT a lot more. :)

Here is the portrait image transparency I used for testing: Transparent Portrait Image

@JamzTheMan
Copy link
Member

I'm wondering if there should be an option for this? Sometimes you may not want the portrait to be at the same zoom/scale used for the token. Sometimes you end up wanting to use a portrait background that is wide enough but not high enough to fit the portrait view.

Definitely what looks good for the Token may not look good for the Portrait, but not sure how to portray that and keep the UI minimal?

Maybe utilize some space in the Background Options pane?

@melek
Copy link
Author

melek commented Apr 3, 2021

I personally can't imagine designing an image that just happens to be a perfect visual fit given the current behavior, but an option would be better than no option!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants