Skip to content

Commit

Permalink
Merge branch 'main' of github.com:RichSteini/Details-TBC-2.4.3 into main
Browse files Browse the repository at this point in the history
  • Loading branch information
@RichSteini
RichSteini committed Aug 29, 2023
2 parents 064d0da + ecc1332 commit 572487e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 108 deletions.
109 changes: 1 addition & 108 deletions Details/!compatibility/compatibility.lua
View file
Expand Up @@ -115,114 +115,6 @@ while spellIdCacheMisses < 53000 do
end
]]

-- UnitAura now parses the spellId from the spellLink, spellIdCache not used atm
function UnitAura(unit, indexOrName, rank, filter)
--[[
local aura_index, aura_name, aura_type
if type(indexOrName) ~= "number" then
aura_name = indexOrName
else
aura_index = indexOrName
end
if not filter and rank then
if type(rank) ~= "number" and rank:find("[HELPFUL,HARMFUL,PLAYER,RAID,CANCELABLE,NOT_CANCELABLE]") then
filter = rank
rank = nil
else
filter = "HELPFUL" -- default value https://wowwiki.fandom.com/wiki/API_UnitAura
end
end
if aura_name then
local i = 1
while true do
name, r, icon, count, duration, expirationTime = UnitBuff(unit, i, filter)
i = i + 1
end
end
--]]
local argCount = filter and 4 or 3
local debuffType
if ((filter and filter:find("HARMFUL")) or ((rank and rank:find("HARMFUL")) and filter == nil)) then
debuffType = "HARMFUL";
elseif ((filter and filter:find("HELPFUL")) or ((rank and rank:find("HELPFUL")) and filter == nil)) then
debuffType = "HELPFUL";
else
debuffType = nil;
end
local x;
if(type(indexOrName) == "number") then
x = indexOrName
else
x = 1
end
if (debuffType == "HELPFUL" or debuffType == nil) then
local castable = filter and filter:find("PLAYER") and 1 or nil;
local name, r, icon, count, duration, remaining = UnitBuff(unit, x, castable);
while (name ~= nil) do
if ((name == indexOrName or x == indexOrName) and (rank == nil or rank:find("HARMFUL") or rank:find("HELPFUL") or rank == r)) then
-- Due to a Blizzard bug, having two of the same weapon
-- proc will return nil for the duration of the second proc.
-- Crusader (Holy Strength), Mongoose (Lightning Speed),
-- and Executioner all last 15 seconds.
duration = duration or 15
remaining = remaining or GetPlayerBuffTimeLeft(x)
local spellLink = GetSpellLink(name, r or "")
local maxDurationOrExpirationTime
if argCount == 4 then
maxDurationOrExpirationTime = GetTime() + (remaining or 0)
else
maxDurationOrExpirationTime = remaining or 0
end
if spellLink then
return name, r, icon, count, debuffType, duration, maxDurationOrExpirationTime, (castable and "player"), nil, nil, tonumber(spellLink:match("spell:(%d+)"))
else
return name, r, icon, count, debuffType, duration, maxDurationOrExpirationTime, (castable and "player")
end
end
x = x + 1;
name, r, icon, count, duration, remaining = UnitBuff(unit, x, castable);
end
end
if (debuffType == "HARMFUL" or debuffType == nil) then
local removable = nil
if(type(indexOrName) == "number") then
x = indexOrName
else
x = 1
end
local name, r, icon, count, dispelType, duration, remaining = UnitDebuff(unit, x, removable);
while (name ~= nil) do
if ((name == indexOrName or x == indexOrName) and (rank == nil or rank:find("HARMFUL") or rank:find("HELPFUL") or rank == r)) then
local spellLink = GetSpellLink(name, r or "")
local maxDurationOrExpirationTime
if argCount == 4 then
maxDurationOrExpirationTime = GetTime() + (remaining or 0)
else
maxDurationOrExpirationTime = remaining or 0
end
if spellLink then
return name, r, icon, count, dispelType, duration, maxDurationOrExpirationTime, nil, nil, nil, tonumber(spellLink:match("spell:(%d+)"))
else
return name, r, icon, count, dispelType, duration, maxDurationOrExpirationTime
end
end
x = x + 1;
name, r, icon, count, dispelType, duration, remaining = UnitDebuff(unit, x, removable);
end
end
return nil, nil, nil, nil, nil, 0, 0;
end
function UnitInVehicle(unit)
return false
end
Expand Down Expand Up @@ -273,6 +165,7 @@ function IsUsableSpell(spell, booktype)
else
spell = SpellID_to_SpellName(spell)
if spell then
spell = (string.gsub(spell, "%)$",")()"))
return hooks.IsUsableSpell(spell) -- вызываем оригинал
else
return nil
Expand Down
6 changes: 6 additions & 0 deletions README.md
View file
@@ -0,0 +1,6 @@
# Details-TBC-2.4.3
Details! backported for TBC 2.4.3

Raider or PVP player doesn’t matter, we are always searching for more Intel, ways to make deep analyses, and methods to know everything that’s going on around us. From casual to theory crafter, knowledge is essential for growing as a player. If you fit in this profile, if you want to know from a simple “how much damage I’m doing” to more complex “how many times a healer casted that cooldown on the main tank”, Details! is an addon for you!

![grafik](https://github.com/RichSteini/Details-TBC-2.4.3/assets/50737013/acc80500-7585-4c08-aab3-5b1451899bec)

0 comments on commit 572487e

Please sign in to comment.