From 67b6435215925244c6ed3bc42ca46014ec595bdf Mon Sep 17 00:00:00 2001 From: Macumba Date: Thu, 25 May 2023 16:57:06 +0200 Subject: [PATCH 1/4] Create README.md Hardc0re <3 --- README.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 README.md diff --git a/README.md b/README.md new file mode 100644 index 0000000..992080c --- /dev/null +++ b/README.md @@ -0,0 +1,6 @@ +# Details-TBC-2.4.3 +Details! backported for TBC 2.4.3 + +Raider or PVP player doesn’t matter, we are always searching for more Intel, ways to make deep analyses, and methods to know everything that’s going on around us. From casual to theory crafter, knowledge is essential for growing as a player. If you fit in this profile, if you want to know from a simple “how much damage I’m doing” to more complex “how many times a healer casted that cooldown on the main tank”, Details! is an addon for you! + +![image](https://github.com/RichSteini/Details-TBC-2.4.3/assets/47739411/aae7ae4c-1e46-4ae3-bc16-230b483a4d2c) From 8a119f6b24729be33c0ad9682ecd0e5d6a419e53 Mon Sep 17 00:00:00 2001 From: RichSteini <50737013+RichSteini@users.noreply.github.com> Date: Fri, 26 May 2023 19:42:32 +0200 Subject: [PATCH 2/4] Update image in README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 992080c..769a4ef 100644 --- a/README.md +++ b/README.md @@ -3,4 +3,4 @@ Details! backported for TBC 2.4.3 Raider or PVP player doesn’t matter, we are always searching for more Intel, ways to make deep analyses, and methods to know everything that’s going on around us. From casual to theory crafter, knowledge is essential for growing as a player. If you fit in this profile, if you want to know from a simple “how much damage I’m doing” to more complex “how many times a healer casted that cooldown on the main tank”, Details! is an addon for you! -![image](https://github.com/RichSteini/Details-TBC-2.4.3/assets/47739411/aae7ae4c-1e46-4ae3-bc16-230b483a4d2c) +![grafik](https://github.com/RichSteini/Details-TBC-2.4.3/assets/50737013/acc80500-7585-4c08-aab3-5b1451899bec) From 4fadbc4d6de79da0852bbd45091fa6aa29523e14 Mon Sep 17 00:00:00 2001 From: RichSteini <50737013+RichSteini@users.noreply.github.com> Date: Tue, 20 Jun 2023 12:14:07 +0200 Subject: [PATCH 3/4] Remove custom UnitAura function --- Details/!compatibility/compatibility.lua | 108 ----------------------- 1 file changed, 108 deletions(-) diff --git a/Details/!compatibility/compatibility.lua b/Details/!compatibility/compatibility.lua index e8f98d7..5814993 100644 --- a/Details/!compatibility/compatibility.lua +++ b/Details/!compatibility/compatibility.lua @@ -115,114 +115,6 @@ while spellIdCacheMisses < 53000 do end ]] --- UnitAura now parses the spellId from the spellLink, spellIdCache not used atm -function UnitAura(unit, indexOrName, rank, filter) - --[[ - local aura_index, aura_name, aura_type - if type(indexOrName) ~= "number" then - aura_name = indexOrName - else - aura_index = indexOrName - end - if not filter and rank then - if type(rank) ~= "number" and rank:find("[HELPFUL,HARMFUL,PLAYER,RAID,CANCELABLE,NOT_CANCELABLE]") then - filter = rank - rank = nil - else - filter = "HELPFUL" -- default value https://wowwiki.fandom.com/wiki/API_UnitAura - end - end - - if aura_name then - local i = 1 - while true do - name, r, icon, count, duration, expirationTime = UnitBuff(unit, i, filter) - - i = i + 1 - end - end - --]] - local argCount = filter and 4 or 3 - local debuffType - - if ((filter and filter:find("HARMFUL")) or ((rank and rank:find("HARMFUL")) and filter == nil)) then - debuffType = "HARMFUL"; - elseif ((filter and filter:find("HELPFUL")) or ((rank and rank:find("HELPFUL")) and filter == nil)) then - debuffType = "HELPFUL"; - else - debuffType = nil; - end - - local x; - if(type(indexOrName) == "number") then - x = indexOrName - else - x = 1 - end - - if (debuffType == "HELPFUL" or debuffType == nil) then - local castable = filter and filter:find("PLAYER") and 1 or nil; - local name, r, icon, count, duration, remaining = UnitBuff(unit, x, castable); - while (name ~= nil) do - if ((name == indexOrName or x == indexOrName) and (rank == nil or rank:find("HARMFUL") or rank:find("HELPFUL") or rank == r)) then - -- Due to a Blizzard bug, having two of the same weapon - -- proc will return nil for the duration of the second proc. - -- Crusader (Holy Strength), Mongoose (Lightning Speed), - -- and Executioner all last 15 seconds. - duration = duration or 15 - remaining = remaining or GetPlayerBuffTimeLeft(x) - local spellLink = GetSpellLink(name, r or "") - - local maxDurationOrExpirationTime - if argCount == 4 then - maxDurationOrExpirationTime = GetTime() + (remaining or 0) - else - maxDurationOrExpirationTime = remaining or 0 - end - - if spellLink then - return name, r, icon, count, debuffType, duration, maxDurationOrExpirationTime, (castable and "player"), nil, nil, tonumber(spellLink:match("spell:(%d+)")) - else - return name, r, icon, count, debuffType, duration, maxDurationOrExpirationTime, (castable and "player") - end - end - x = x + 1; - name, r, icon, count, duration, remaining = UnitBuff(unit, x, castable); - end - end - - if (debuffType == "HARMFUL" or debuffType == nil) then - local removable = nil - if(type(indexOrName) == "number") then - x = indexOrName - else - x = 1 - end - local name, r, icon, count, dispelType, duration, remaining = UnitDebuff(unit, x, removable); - while (name ~= nil) do - if ((name == indexOrName or x == indexOrName) and (rank == nil or rank:find("HARMFUL") or rank:find("HELPFUL") or rank == r)) then - local spellLink = GetSpellLink(name, r or "") - - local maxDurationOrExpirationTime - if argCount == 4 then - maxDurationOrExpirationTime = GetTime() + (remaining or 0) - else - maxDurationOrExpirationTime = remaining or 0 - end - - if spellLink then - return name, r, icon, count, dispelType, duration, maxDurationOrExpirationTime, nil, nil, nil, tonumber(spellLink:match("spell:(%d+)")) - else - return name, r, icon, count, dispelType, duration, maxDurationOrExpirationTime - end - end - x = x + 1; - name, r, icon, count, dispelType, duration, remaining = UnitDebuff(unit, x, removable); - end - end - return nil, nil, nil, nil, nil, 0, 0; -end - function UnitInVehicle(unit) return false end From ecc1332fbfcb6426895059428c26102ce802d972 Mon Sep 17 00:00:00 2001 From: RichSteini <50737013+RichSteini@users.noreply.github.com> Date: Tue, 20 Jun 2023 12:19:26 +0200 Subject: [PATCH 4/4] IsUsableSpell update spells with parantheses --- Details/!compatibility/compatibility.lua | 1 + 1 file changed, 1 insertion(+) diff --git a/Details/!compatibility/compatibility.lua b/Details/!compatibility/compatibility.lua index 5814993..1d90ea2 100644 --- a/Details/!compatibility/compatibility.lua +++ b/Details/!compatibility/compatibility.lua @@ -165,6 +165,7 @@ function IsUsableSpell(spell, booktype) else spell = SpellID_to_SpellName(spell) if spell then + spell = (string.gsub(spell, "%)$",")()")) return hooks.IsUsableSpell(spell) -- вызываем оригинал else return nil