New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(install): Add back arg `$Name` in `Invoke-Installer()` #5971

Merged

niheaven merged 2 commits into develop from fix-install

May 15, 2024

Member

niheaven commented May 15, 2024 •

edited

Description

The variable $fname might be utilized in both installer.script and post_install, therefore, it should not be removed as initially considered.

Motivation and Context

Relates to refactor(install): Replace 'run_(un)installer()' with 'Invoke-Installer()' #5968

How Has This Been Tested?

Checklist:

I have read the Contributing Guide.
I have ensured that I am targeting the develop branch.
I have updated the documentation accordingly.
I have updated the tests accordingly.
I have added an entry in the CHANGELOG.

niheaven added 2 commits

May 15, 2024 19:17


          fix(install): Add back arg $Name in Invoke-Installer()

2e6b729


          Update chglog

c61724d

niheaven merged commit 8ea3738 into develop

2 checks passed

niheaven deleted the fix-install branch

May 15, 2024 11:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment