[dotnet] remove non-w3c compliant capability code #13026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titusfortner
force-pushed
the
w3c_dotnet
branch
from
145aee8
to
a638dac
Compare
nvborisenko
reviewed
Oct 23, 2023
| @@ -124,28 +79,28 @@ public string BrowserName | |||
| /// <summary> | |||
| /// Gets or sets the platform | |||
| /// </summary> | |||
| public Platform Platform | |||
| public Platform PlatformName | |||
There was a problem hiding this comment.
CI Build fails.
dotnet\src\webdriver\Remote\ReadOnlyDesiredCapabilities.cs(213,148): error CS1061: 'ReadOnlyDesiredCapabilities' does not contain a definition for 'Platform' and no accessible extension method 'Platform' accepting a first argument of type 'ReadOnlyDesiredCapabilities' could be found (are you missing a using directive or an assembly reference?)
|
I think it is still actual. Up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
As best as I can tell, if the capability isn't in this list it gets ignored when starting a session — https://github.com/SeleniumHQ/selenium/blob/selenium-4.14.0/dotnet/src/webdriver/WebDriver.cs#L652-L655
I don't know if the browser version and platform name code is necessary, but if it is looking for the old values it won't work.
Whatever is going on here, it can be cleaned up more, I just made some quick changes while I noticed it.