Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bot] Determine more reliably if node has shadow DOM #13053

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

dlanza1
Copy link

@dlanza1 dlanza1 commented Oct 25, 2023

Description

node.shadowRoot might have an object assigned (some framework working with ShadyDOM does assign an object to node.shadowRoot), but it is no necessarily used by the browser as it must be constructed by ShadowRoot, otherwise is ignored.

Motivation and Context

Mechanisms like bot.dom.isShown() would determine an element is not shown because it believes it does not have parent.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

node.shadowRoot might have an object assigned, but it is no necessarily used
@CLAassistant
Copy link

CLAassistant commented Oct 25, 2023

CLA assistant check
All committers have signed the CLA.

@isaulv isaulv added the D-atoms label Nov 9, 2023
@isaulv
Copy link
Contributor

isaulv commented Nov 9, 2023

So there are libraries using the shadow property to store an object only to be reified as a proper shadow object later? that's interesting.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the late review.

This breaks things in different places. Could you have a look at the builds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants