Merge pull request #1715 from Blueberryy/master

Add notice time to translation file
ajayyy · May 8, 2023 · 68a6286 · 68a6286
2 parents afe7271 + 7960fde
commit 68a6286
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/public/_locales/en/messages.json b/public/_locales/en/messages.json
@@ -1235,5 +1235,9 @@
     },
     "allowScrollingToEdit": {
         "message": "Allow Scrolling To Edit Times"
+    },
+    "NoticeTimeAfterSkip": {
+        "message": "{seconds}s",
+        "description": "This is used on the popup to show how much time left. It will look like \"5s\". The word {seconds} will be replaced, so keep it here. Translations should only change the \"s\""
     }
 }
diff --git a/src/components/NoticeComponent.tsx b/src/components/NoticeComponent.tsx
@@ -195,7 +195,7 @@ class NoticeComponent extends React.Component<NoticeProps, NoticeState> {
                         id={"skipNoticeTimerText" + this.idSuffix}
                         key="skipNoticeTimerText"
                         className={this.state.countdownMode !== CountdownMode.Timer ? "hidden" : ""} >
-                            {this.state.countdownTime + "s"}
+                            {chrome.i18n.getMessage("NoticeTimeAfterSkip").replace("{seconds}", this.state.countdownTime.toString())}
                     </span>
                 ),(
                     <img