Merge pull request #26 from ajayyy/experimental

Fixed bug making player controls only submit integers
ajayyy · Jul 27, 2019 · d654d89 · d654d89
2 parents 64be41b + 97e202d
commit d654d89
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/background.js b/background.js
@@ -74,17 +74,18 @@ function addSponsorTime(time, videoID) {
     //add to sponsorTimes
     if (sponsorTimes.length > 0 && sponsorTimes[sponsorTimes.length - 1].length < 2) {
       //it is an end time
-      sponsorTimes[sponsorTimes.length - 1][1] = parseInt(time);
+      sponsorTimes[sponsorTimes.length - 1][1] = time;
     } else {
       //it is a start time
       let sponsorTimesIndex = sponsorTimes.length;
       sponsorTimes[sponsorTimesIndex] = [];
 
-      sponsorTimes[sponsorTimesIndex][0] = parseInt(time);
+      sponsorTimes[sponsorTimesIndex][0] = time;
     }
 
     //save this info
     let sponsorTimeKey = "sponsorTimes" + videoID;
+    console.log(sponsorTimes)
     chrome.storage.sync.set({[sponsorTimeKey]: sponsorTimes});
   });
 }
@@ -123,6 +124,9 @@ function submitTimes(videoID, callback) {
       for (let i = 0; i < sponsorTimes.length; i++) {
         getUserID(function(userIDStorage) {
           //submit the sponsorTime
+          console.log(sponsorTimes)
+          console.log("/api/postVideoSponsorTimes?videoID=" + videoID + "&startTime=" + sponsorTimes[i][0] + "&endTime=" + sponsorTimes[i][1]
+          + "&userID=" + userIDStorage)
           sendRequestToServer('GET', "/api/postVideoSponsorTimes?videoID=" + videoID + "&startTime=" + sponsorTimes[i][0] + "&endTime=" + sponsorTimes[i][1]
           + "&userID=" + userIDStorage, function(xmlhttp, error) {
             if (xmlhttp.readyState == 4 && !error) {

diff --git a/firefox_manifest.json b/firefox_manifest.json
@@ -1,7 +1,7 @@
 {
   "name": "SponsorBlock - YouTube Sponsorship Blocker",
   "short_name": "SponsorBlock",
-  "version": "1.0.7",
+  "version": "1.0.8",
   "description": "Skip over sponsorship on YouTube videos. Report sponsors on videos you watch to save the time of others.",
   "content_scripts": [
     {

diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
   "name": "SponsorBlock - YouTube Sponsorship Blocker",
   "short_name": "SponsorBlock",
-  "version": "1.0.7",
+  "version": "1.0.8",
   "description": "Skip over sponsorship on YouTube videos. Report sponsors on videos you watch to save the time of others.",
   "content_scripts": [
     {