Unproportional mosaicing #1389
Open
Unproportional mosaicing #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dipet
requested changes
Feb 1, 2023
| tiles = np.asarray(tiles) | ||
|
|
||
| shape_y, shape_x = tiles.shape | ||
| shuffled_ids = np.linspace(0, shape_y - 1, shape_y, dtype=np.int32).tolist() |
There was a problem hiding this comment.
Do not save them into class member. Return as an argument.
| def apply_to_keypoint(self, keypoint, **params): | ||
| return () | ||
|
|
||
| def get_params_dependent_on_targets(self, params): |
There was a problem hiding this comment.
Need to implement targets_as_params to use this method.
Comment on lines
+2712
to
+2714
| num_segments = params["num_segments"] if "num_segments" in params else 7 | ||
| ratio = params["ratio"] if "ratio" in params else 4.0 / 3.0 | ||
| # refinement_steps = params["refinement_steps"] if "refinement_steps" in params else 10 |
There was a problem hiding this comment.
Mabe better to use it as an augmentation argument on creation. Also we could rewrite it if it will be provided on transform call.
| index = 0 | ||
|
|
||
| # We must work with the copy because "Split" alters the original list | ||
| segms_copy = segms.copy() |
| # We must work with the copy because "Split" alters the original list | ||
| segms_copy = segms.copy() | ||
|
|
||
| for segm in segms_copy: |
There was a problem hiding this comment.
@Dipet I would like to ask you what do you mean by enum. You mean enumerate function?
There was a problem hiding this comment.
Replace
index = 0
# We must work with the copy because "Split" alters the original list
segms_copy = segms.copy()
for segm in segms_copy:with:
# We must work with the copy because "Split" alters the original list
segms_copy = segms.copy()
for index, segm in enumerate(segms_copy):| return True | ||
|
|
||
| # Split | ||
| current_num_semgs = 1 |
|
Hi there, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to contribute to project Albumentations with new augmentation named Unproportional mosaicing.