Cleanup in pre-commit #1709
Merged
Cleanup in pre-commit #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
ternaus
added a commit
that referenced
this pull request
May 8, 2024
* Bigfix (#1665) * Bigfix * Cleanup * Boosted version to 1.4.4 (#1666) * move deterministic warn from __call__ to init (#1669) * check_each_transform - move calculation from`__call__` to init (#1670) * check_each_transform - move calculation from`__call__` to init * check additional_targets at check_data_post_transform --------- Co-authored-by: Vladimir Iglovikov <ternaus@users.noreply.github.com> * docstring for BasicTransform (#1662) * docstring for BasicTransform * Update albumentations/core/transforms_interface.py Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> * Update transforms_interface.py Fixes for ruff * Update transforms_interface.py Ruff fixes * Update transforms_interface.py ruff fixes --------- Co-authored-by: Vladimir Iglovikov <ternaus@users.noreply.github.com> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> * Add bbox clipping (#1671) * Fix * Added option to crop boxes * Fix in docs * Sourcery proposals * check parameters are valid (#1673) * Fix bbox clipping (#1675) * Fix in bbox clipping * Fix in bbox clipping * Added how agressively we can modify the code (#1678) * Change course dropout interface (#1677) * Updated CoarseDropout interface * Fix in tests * Fix in tests * Updated docstring * Cleanup * Fix for pyhton 3.10+ * Fix in hole size range * Possible fix in ranges * Update test_transforms.py Cleanup * Hopefully will fix conda issues (#1681) * Fix random crop from borders (#1682) * Fix in RandomCropFromBorders * Cleanup * Added downloads and stackoverflow badges (#1683) * Fix d4 (#1686) * tests pass * Fix in D4 * removed preserve shape * Cleanup * fix in CI * Updates in CI * Fix in CI * Fix in CI * Pr 1679 (#1687) * Adds error message to the add_label_fields_to_data function. When the lengths os bboxes and labels mismatch, raise the ValueError with a proper error message. * Fixed minor error to enable merging of PR #1679 --------- Co-authored-by: Wilder Rodrigues <wilder.rodrigues@gmail.com> * Fix in ToGray (#1688) * Fix in CoarseDropout (#1689) * Channel subset (#1690) * Added SelectiveChannelTransform * Added SelectiveChannelTransform * Added SelectiveChannelTransform * Fix in tests * Clean in tranforms * Fix in GridDistortion docstring (#1695) * Fix in GridDistortion docstring * Fix in GridDistortion docstring * Available keys at BasicTransform and BaseCompose (#1692) * docstring for BasicTransform * targets2func base * _targets2func * transform fix from comments * ToTensorV2 fix * fix set_target * remove target_dependence * Compose - move calculation always_apply to init * Revert "docstring for BasicTransform" This reverts commit b3076e4. * fix merge * available_keys at compose * fix compose, basic_transform, tests * fix _set_keys at compose, fix tests * _check_args, fix tests * version boosted to 1.4.5 (#1696) * processor does process / preprocess only if key exists (#1697) * processor does process / preprocess only if key exists * tests compose_without_keys * fix remove_label_fields_from_data * Fix blur (#1700) * Added heavy refactoring * Added heavy refactoring * Updated interface for Downscale * Updated Downscale transform * Fix in CI * Revert 1692 (#1702) * Revert "Available keys at BasicTransform and BaseCompose (#1692)" This reverts commit ee3c634. * Add tests for common pipelines check * Update test * Pr 1619 (#1704) * update ImageCompression interface * changed DeprecationWarning mechanism * modified tests * fixed pre-commit * Refactoring * Fix in CI * Fix in CI * Fix in CI --------- Co-authored-by: Lorenzo <lmarogna02@gmail.com> Co-authored-by: Lorenzo <99410146+MarognaLorenzo@users.noreply.github.com> * Cleanup in pre-commit (#1709) * Available keys at Compose and Transform (#1706) * docstring for BasicTransform * targets2func base * _targets2func * transform fix from comments * ToTensorV2 fix * fix set_target * remove target_dependence * Compose - move calculation always_apply to init * Revert "docstring for BasicTransform" This reverts commit b3076e4. * fix merge * available_keys at compose * fix compose, basic_transform, tests * fix _set_keys at compose, fix tests * _check_args, fix tests * fix _set_keys, add warning if no processors for key --------- Co-authored-by: Vladimir Iglovikov <ternaus@users.noreply.github.com> * draft for compose with return applied params --------- Co-authored-by: Vladimir Iglovikov <ternaus@users.noreply.github.com> Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com> Co-authored-by: Wilder Rodrigues <wilder.rodrigues@gmail.com> Co-authored-by: Mikhail Druzhinin <dipetm@gmail.com> Co-authored-by: Lorenzo <lmarogna02@gmail.com> Co-authored-by: Lorenzo <99410146+MarognaLorenzo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.