Add version check

[ternaus]

No description provided.

[sourcery-ai]

Hey @ternaus - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 4 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[Antinomy20001]

We have noticed that the check_for_updates function only handles exceptions for certain cases (network exceptions). It does not fully cover the scenarios in complex network environments. However, this function will be called whenever 'import albumentations' is executed, which indicates its incompleteness.

albumentations/albumentations/check_version.py

Line 8 in ae57e12

def check_for_updates() -> None:

eg:

• data = response.read() but response read timeout
• json_data = json.loads(data.decode(encoding)) but decoded data is not a json
• latest_version = json_data["info"]["version"] but there are Key Errors in json_data

Considering complex scenarios such as intranet environments, hijacking, and reverse proxies, it is not sufficient to merely handle exceptions related to the network connection itself.

[ternaus]

Thanks.

Will make exception general

Correct me, if I am wrong, but regardless of the exception type, nothing happens as it is just a pass after that.

[ternaus]

Made exception more general in #1725