Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debconf: set empty password value #83217

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented May 8, 2024

SUMMARY

Fixes: #83214

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. module This issue/PR relates to a module. has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 8, 2024
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label May 8, 2024
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label May 14, 2024
Fixes: ansible#83214

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label May 14, 2024
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label May 14, 2024
@Akasurde Akasurde requested a review from bcoca May 14, 2024 21:47
if dquestion == question and dvtype == vtype:
if len(dvalue) >= 1:
return dvalue[0]
return ''

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are changing the logic for not found, since desired_line will always be true when leaving the loop, the error handler will be wrong

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug. has_issue module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debconf: MODULE FAILURE (not enough values to unpack (expected 4, got 3))
4 participants