autorepair v2 framework #3306
Open
autorepair v2 framework #3306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaydeepkumar1984
commented
May 13, 2024
jaydeepkumar1984
commented
- AutoRepir v2 framework that covers both FR & IR
- An interface with a default implementation for TokenRange calculation
- Enable/Disable flag as a CQL Table property
jaydeepkumar1984
force-pushed
the
auto_repair_v2
branch
from
93d7b83
to
154c790
Compare
kzalys
reviewed
May 15, 2024
| ColumnFamilyStore columnFamilyStore = keyspace.getColumnFamilyStore(tableName); | ||
| if (columnFamilyStore.metadata().params.disableAutomatedRepair) | ||
| { | ||
| logger.info("Repair is disabled for keyspace {} for tables: {}", keyspaceName, tableName); |
There was a problem hiding this comment.
Suggested change
| logger.info("Repair is disabled for keyspace {} for tables: {}", keyspaceName, tableName); | |
| logger.info("Repair is disabled for keyspace {} for table: {}", keyspaceName, tableName); |
kzalys
reviewed
May 15, 2024
|
|
||
| public void setRepairMinIntervalInHours(RepairType repairType, int repairMinFrequencyInHours) | ||
| { | ||
| repair_type_overrides.get(repairType).min_repair_interval_in_hours = repairMinFrequencyInHours; |
There was a problem hiding this comment.
JFYI, there's a bug in these setters. If you provide a config in cassandra.yaml such as the following
auto_repair:
repair_type_overrides:
full:
enabled: true
repair_type_overrides.get("incremental") will be null and we'll get an NPE if we call a setter with incremental repair type
There was a problem hiding this comment.
Though this only affects nodetool functionality
jaydeepkumar1984
force-pushed
the
auto_repair_v2
branch
2 times, most recently
from
e225d41
to
27dcbf2
Compare
jaydeepkumar1984
force-pushed
the
auto_repair_v2
branch
from
27dcbf2
to
75798ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.