Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle icon blocks LastPass auto-fill icon #53

Open
jacobg opened this issue Nov 5, 2020 · 2 comments
Open

Toggle icon blocks LastPass auto-fill icon #53

jacobg opened this issue Nov 5, 2020 · 2 comments

Comments

@jacobg
Copy link

jacobg commented Nov 5, 2020

Expected Behavior

Should be able to auto-fill password by clicking on LastPass icon at right side of input box. This refers to the LastPass's Chrome extension.

Actual Behavior

Toggle icon displays over the LastPass icon, and is not clickable. There probably needs to be more right margin added to move the toggle icon to the left. Any other icon options used by vue-password-strength-meter should also be moved further to the left.

Screen Shot 2020-11-05 at 3 15 31 PM

Environment

  • OS: Mac/Windows
  • NPM version: 6.14.8
  • vue.js version: 2.6.11
  • vue-password-strength-meter version: 1.7.1
@andreipopovici
Copy link

Here's a clever way to fix this, courtesy of the big G: https://core.trac.wordpress.org/timeline?from=2019-10-06T11%3A10%3A40Z&precision=second

Google makes the input look like it ends beyond the icon, but that's a visual trick. The input field is shorter and (in this repo's case) .Password__icons sits outside the input field, not on top of it via position: absolute.

This might be a good idea, since it would ensure that both the character counter and the toggle icon would be safe from anything being inserted into (or on top of) the input field by password managers, browser or third-party.

@andreipopovici
Copy link

That link seems to be broken, but the gist of it is reproduced in this Codepen: https://codepen.io/skttl/pen/NzxMVV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants