Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Implement OTA delay and allow overriding default transport #265

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

facchinm
Copy link
Contributor

@facchinm facchinm commented Jul 2, 2021

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2021

Codecov Report

Patch and project coverage have no change.

Comparison is base (c8eac59) 95.15% compared to head (b35be00) 95.15%.
Report is 350 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files          24       24           
  Lines         867      867           
=======================================
  Hits          825      825           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

Memory usage change @ b35be00

Board flash % RAM for global variables %
arduino:mbed:envie_m4 🔺 0 - +64 0.0 - +0.01 🔺 +8 - +8 0.0 - 0.0
arduino:mbed:envie_m7 🔺 0 - +64 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 0 - +48 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 +8 - +8 0.0 - 0.0 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrgsm1400 🔺 +48 - +48 +0.02 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 🔺 +8 - +8 0.0 - 0.0 🔺 +8 - +8 +0.02 - +0.02
arduino:samd:mkrwan1300 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +56 0.0 - +0.02 🔺 0 - +8 0.0 - +0.02
arduino:samd:nano_33_iot 🔺 0 - +56 0.0 - +0.02 🔺 0 - +8 0.0 - +0.02
esp32:esp32:esp32 🔺 +4 - +4 0.0 - 0.0 🔺 0 - +8 0.0 - 0.0
esp8266:esp8266:huzzah 🔺 0 - +16 0.0 - 0.0 🔺 0 - +16 0.0 - +0.02
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
% examples/ArduinoIoTCloud-Advanced
RAM for global variables
% examples/ArduinoIoTCloud-Basic
flash
% examples/ArduinoIoTCloud-Basic
RAM for global variables
% examples/utility/ArduinoIoTCloud_Travis_CI
flash
% examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
% examples/utility/Provisioning
flash
% examples/utility/Provisioning
RAM for global variables
% examples/utility/SelfProvisioning
flash
% examples/utility/SelfProvisioning
RAM for global variables
%
arduino:mbed:envie_m4 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 64 0.01 8 0.0
arduino:mbed:envie_m7 64 0.01 0 0.0 0 0.0 0 0.0 64 0.01 0 0.0 64 0.01 0 0.0
arduino:mbed_nano:nanorp2040connect 48 0.0 0 0.0 48 0.0 0 0.0 48 0.0 0 0.0 48 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 8 0.0 8 0.02 8 0.0 8 0.02 8 0.0 8 0.02 8 0.0 8 0.02
arduino:samd:mkrgsm1400 48 0.02 0 0.0 48 0.02 0 0.0 48 0.02 0 0.0 48 0.02 0 0.0
arduino:samd:mkrnb1500 8 0.0 8 0.02 8 0.0 8 0.02 8 0.0 8 0.02 8 0.0 8 0.02
arduino:samd:mkrwan1300 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 56 0.02 8 0.02 48 0.02 0 0.0 48 0.02 0 0.0 56 0.02 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 56 0.02 8 0.02 48 0.02 0 0.0 48 0.02 0 0.0 48 0.02 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 4 0.0 0 0.0 4 0.0 8 0.0 4 0.0 8 0.0
esp8266:esp8266:huzzah 0 0.0 16 0.02 16 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,64,0.01,8,0.0
arduino:mbed:envie_m7,64,0.01,0,0.0,0,0.0,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0
arduino:mbed_nano:nanorp2040connect,48,0.0,0,0.0,48,0.0,0,0.0,48,0.0,0,0.0,48,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,,,,
arduino:samd:mkrgsm1400,48,0.02,0,0.0,48,0.02,0,0.0,48,0.02,0,0.0,48,0.02,0,0.0,,,,
arduino:samd:mkrnb1500,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,8,0.0,8,0.02,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:samd:mkrwifi1010,56,0.02,8,0.02,48,0.02,0,0.0,48,0.02,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,56,0.02,8,0.02,48,0.02,0,0.0,48,0.02,0,0.0,48,0.02,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,4,0.0,0,0.0,4,0.0,8,0.0,4,0.0,8,0.0,,,,,,,,
esp8266:esp8266:huzzah,0,0.0,16,0.02,16,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,

@manchoz
Copy link
Contributor

manchoz commented Aug 4, 2021

LGTM

@pennam pennam mentioned this pull request Oct 20, 2021
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants