Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thing property reconfiguration after wifi loss #459

Merged

Conversation

pennam
Copy link
Collaborator

@pennam pennam commented May 15, 2024

Bug was introduced with #445 already fixed in #455 using new command topic.

I tought it was better to backport and fix also for the property implementation.

Copy link

Memory usage change @ c870a72

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 +36 - +68 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_edge:edge_control 🔺 +64 - +128 +0.01 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_giga:giga 🔺 0 - +64 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 0 - +72 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 0 - +128 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 🔺 0 - +64 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 0 - +80 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi 🔺 +80 - +80 +0.03 - +0.03 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 0 - +72 0.0 - +0.03 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 0 - +72 0.0 - +0.03 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 🔺 0 - +72 0.0 - +0.03 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +80 0.0 - +0.03 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 🔺 0 - +80 0.0 - +0.03 0 - 0 0.0 - 0.0
esp32:esp32:esp32 🔺 +60 - +72 0.0 - +0.01 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 🔺 +64 - +64 +0.01 - +0.01 0 - 0 0.0 - 0.0
Click for full report table
Board examples/ArduinoIoTCloud-Advanced
flash
% examples/ArduinoIoTCloud-Advanced
RAM for global variables
% examples/ArduinoIoTCloud-Basic
flash
% examples/ArduinoIoTCloud-Basic
RAM for global variables
% examples/ArduinoIoTCloud-Callbacks
flash
% examples/ArduinoIoTCloud-Callbacks
RAM for global variables
% examples/ArduinoIoTCloud-Schedule
flash
% examples/ArduinoIoTCloud-Schedule
RAM for global variables
% examples/utility/ArduinoIoTCloud_Travis_CI
flash
% examples/utility/ArduinoIoTCloud_Travis_CI
RAM for global variables
% examples/ArduinoIoTCloud-DeferredOTA
flash
% examples/ArduinoIoTCloud-DeferredOTA
RAM for global variables
% examples/utility/Provisioning
flash
% examples/utility/Provisioning
RAM for global variables
% examples/utility/SelfProvisioning
flash
% examples/utility/SelfProvisioning
RAM for global variables
%
arduino:esp32:nano_nora 60 0.0 0 0.0 36 0.0 0 0.0 60 0.0 0 0.0 68 0.0 0 0.0 60 0.0 0 0.0 60 0.0 0 0.0
arduino:mbed_edge:edge_control 128 0.01 0 0.0 64 0.01 0 0.0 64 0.01 0 0.0 64 0.01 0 0.0 64 0.01 0 0.0
arduino:mbed_giga:giga 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 72 0.0 0 0.0 72 0.0 0 0.0 72 0.0 0 0.0 72 0.0 0 0.0 72 0.0 0 0.0 72 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 128 0.01 0 0.0 128 0.01 0 0.0 128 0.01 0 0.0 64 0.0 0 0.0 128 0.01 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_opta:opta 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 80 0.0 0 0.0 80 0.0 0 0.0 80 0.0 0 0.0 80 0.0 0 0.0 80 0.0 0 0.0 0 0.0 0 0.0
arduino:renesas_uno:unor4wifi 80 0.03 0 0.0 80 0.03 0 0.0 80 0.03 0 0.0 80 0.03 0 0.0 80 0.03 0 0.0
arduino:samd:mkr1000 72 0.03 0 0.0 72 0.03 0 0.0 72 0.03 0 0.0 72 0.03 0 0.0 72 0.03 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 72 0.03 0 0.0 72 0.03 0 0.0 72 0.03 0 0.0 72 0.03 0 0.0 72 0.03 0 0.0 0 0.0 0 0.0
arduino:samd:mkrnb1500 72 0.03 0 0.0 72 0.03 0 0.0 72 0.03 0 0.0 72 0.03 0 0.0 72 0.03 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 80 0.03 0 0.0 80 0.03 0 0.0 72 0.03 0 0.0 80 0.03 0 0.0 72 0.03 0 0.0 72 0.03 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 80 0.03 0 0.0 80 0.03 0 0.0 72 0.03 0 0.0 80 0.03 0 0.0 72 0.03 0 0.0 72 0.03 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 64 0.0 0 0.0 60 0.0 0 0.0 72 0.01 0 0.0 64 0.0 0 0.0 64 0.0 0 0.0 72 0.01 0 0.0
esp8266:esp8266:huzzah 64 0.01 0 0.0 64 0.01 0 0.0 64 0.01 0 0.0 64 0.01 0 0.0 64 0.01 0 0.0
Click for full report CSV
Board,examples/ArduinoIoTCloud-Advanced<br>flash,%,examples/ArduinoIoTCloud-Advanced<br>RAM for global variables,%,examples/ArduinoIoTCloud-Basic<br>flash,%,examples/ArduinoIoTCloud-Basic<br>RAM for global variables,%,examples/ArduinoIoTCloud-Callbacks<br>flash,%,examples/ArduinoIoTCloud-Callbacks<br>RAM for global variables,%,examples/ArduinoIoTCloud-Schedule<br>flash,%,examples/ArduinoIoTCloud-Schedule<br>RAM for global variables,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>flash,%,examples/utility/ArduinoIoTCloud_Travis_CI<br>RAM for global variables,%,examples/ArduinoIoTCloud-DeferredOTA<br>flash,%,examples/ArduinoIoTCloud-DeferredOTA<br>RAM for global variables,%,examples/utility/Provisioning<br>flash,%,examples/utility/Provisioning<br>RAM for global variables,%,examples/utility/SelfProvisioning<br>flash,%,examples/utility/SelfProvisioning<br>RAM for global variables,%
arduino:esp32:nano_nora,60,0.0,0,0.0,36,0.0,0,0.0,60,0.0,0,0.0,68,0.0,0,0.0,60,0.0,0,0.0,60,0.0,0,0.0
arduino:mbed_edge:edge_control,128,0.01,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0,,,,
arduino:mbed_giga:giga,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,72,0.0,0,0.0,72,0.0,0,0.0,72,0.0,0,0.0,72,0.0,0,0.0,72,0.0,0,0.0,72,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,128,0.01,0,0.0,128,0.01,0,0.0,128,0.01,0,0.0,64,0.0,0,0.0,128,0.01,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_opta:opta,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,0,0.0,0,0.0,,,,
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A,,,,
arduino:renesas_portenta:portenta_c33,80,0.0,0,0.0,80,0.0,0,0.0,80,0.0,0,0.0,80,0.0,0,0.0,80,0.0,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:renesas_uno:unor4wifi,80,0.03,0,0.0,80,0.03,0,0.0,80,0.03,0,0.0,80,0.03,0,0.0,80,0.03,0,0.0,,,,,,,,,,,,
arduino:samd:mkr1000,72,0.03,0,0.0,72,0.03,0,0.0,72,0.03,0,0.0,72,0.03,0,0.0,72,0.03,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrgsm1400,72,0.03,0,0.0,72,0.03,0,0.0,72,0.03,0,0.0,72,0.03,0,0.0,72,0.03,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrnb1500,72,0.03,0,0.0,72,0.03,0,0.0,72,0.03,0,0.0,72,0.03,0,0.0,72,0.03,0,0.0,,,,,0,0.0,0,0.0,,,,
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,,,,,
arduino:samd:mkrwifi1010,80,0.03,0,0.0,80,0.03,0,0.0,72,0.03,0,0.0,80,0.03,0,0.0,72,0.03,0,0.0,72,0.03,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,80,0.03,0,0.0,80,0.03,0,0.0,72,0.03,0,0.0,80,0.03,0,0.0,72,0.03,0,0.0,72,0.03,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,64,0.0,0,0.0,60,0.0,0,0.0,72,0.01,0,0.0,64,0.0,0,0.0,64,0.0,0,0.0,72,0.01,0,0.0,,,,,,,,
esp8266:esp8266:huzzah,64,0.01,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0,64,0.01,0,0.0,,,,,,,,,,,,

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (881e1ca) to head (c870a72).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #459   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files          27       27           
  Lines        1231     1231           
=======================================
  Hits         1170     1170           
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pennam pennam merged commit 502590b into arduino-libraries:master May 16, 2024
23 checks passed
@pennam pennam deleted the fix-thing-property-on-wifi-loss branch May 17, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants