Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interrupt feature #10

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

marqdevx
Copy link
Member

@marqdevx marqdevx commented Jun 7, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 7, 2021

Memory usage change @ b82d9c6

Board flash % RAM for global variables %
arduino:mbed_nano:nano33ble 🔺 +64 - +64 +0.01 - +0.01 0 - 0 0.0 - 0.0
Click for full report table
Board examples/ConfigInterrupt
flash
% examples/ConfigInterrupt
RAM for global variables
% examples/ReadPressure
flash
% examples/ReadPressure
RAM for global variables
% examples/ReadPressureImperial
flash
% examples/ReadPressureImperial
RAM for global variables
%
arduino:mbed_nano:nano33ble N/A N/A N/A N/A 64 0.01 0 0.0 64 0.01 0 0.0
Click for full report CSV
Board,examples/ConfigInterrupt<br>flash,%,examples/ConfigInterrupt<br>RAM for global variables,%,examples/ReadPressure<br>flash,%,examples/ReadPressure<br>RAM for global variables,%,examples/ReadPressureImperial<br>flash,%,examples/ReadPressureImperial<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,N/A,N/A,N/A,N/A,64,0.01,0,0.0,64,0.01,0,0.0

Copy link
Contributor

@Rocketct Rocketct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all this function need to enable the interrupt? if all of them are required it is better put all inside one unique API, if the API can be used alone and have effect that are not involved with interrupt(i mean that the user could do some action non involved with interrupt), of course if you implement a enable interrupt you shall do a disable interrupt that do the inverse action of all these API

Copy link
Contributor

@Rocketct Rocketct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this not works we already used this and was changed here the commit:
d3d6bac

the reasons as mentioned by the comment is that the correct flow have to:

If the ONE_SHOT bit in CTRL_REG2 (11h) is set to '1', One-shot mode is triggered and a new acquisition starts when it is required. Enabling this mode is possible only if the device was previously in power-down mode (ODR bits set to '000'). Once the acquisition is completed and the output registers updated, the device automatically enters in power-down mode. ONE_SHOT bit self-clears itself.

@aentinger
Copy link
Contributor

Hi @marqdevx 👋 Please iterate upon @Rocketct feedback or close this PR, if no longer relevant.

@aentinger
Copy link
Contributor

Ping ... @marqdevx 👋 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants