Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid conflicts with similar declaration of MAX_SOCK_NUM #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Max19thl
Copy link

Great! it was surprise for me now, that yield() also defined as weak function. Thanks!
However, definition of some ethernet library specific handler might allow to avoid re-enterability issues when ethernet functions will be invoked indirectly from yield() handler
in case if some "ethernetYield" will be redefined in sketch , it will be possible to raise some global flags before normal yield() to prevent nested lib invocation.
So, my suggestion to use ethernetYield() weak handler execution in loops inside lib, and to define default weak handler with normal yield(); execution inside
It looks slightly more flexible.

@Max19thl Max19thl closed this Aug 11, 2020
@Max19thl Max19thl reopened this Aug 11, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants