Fix erroneous return value of EthernetClient::write()

[margaretselzer]

Fix the issue that the method always returned the incoming size
parameter regardless of how many bytes were actually sent by
EthernetClass::socketSend(). The return value was always wrong if the
data size was bigger than the socket buffer size.

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Memory usage change @ 50d62a2

Board	flash	%	RAM for global variables	%
arduino:avr:leonardo	💚 -14 - 0	-0.05 - 0.0	0 - 0	0.0 - 0.0
arduino:avr:mega	💚 -14 - 0	-0.01 - 0.0	0 - 0	0.0 - 0.0
arduino:avr:nano	💚 -14 - 0	-0.05 - 0.0	0 - 0	0.0 - 0.0
arduino:megaavr:nona4809	❔ -14 - +8	-0.03 - +0.02	0 - 0	0.0 - 0.0
arduino:megaavr:uno2018	❔ -14 - +8	-0.03 - +0.02	0 - 0	0.0 - 0.0
arduino:sam:arduino_due_x_dbg	💚 -8 - 0	-0.0 - 0.0	N/A	N/A
arduino:samd:arduino_zero_edbg	💚 -4 - 0	-0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkr1000	💚 -4 - 0	-0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrfox1200	💚 -4 - 0	-0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrgsm1400	💚 -4 - 0	-0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrnb1500	💚 -4 - 0	-0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrvidor4000	💚 -4 - 0	-0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1300	💚 -4 - 0	-0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwan1310	💚 -4 - 0	-0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrwifi1010	💚 -4 - 0	-0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:mkrzero	💚 -4 - 0	-0.0 - 0.0	0 - 0	0.0 - 0.0
arduino:samd:nano_33_iot	💚 -4 - 0	-0.0 - 0.0	0 - 0	0.0 - 0.0

Click for full report table

Board	examples/AdvancedChatServer flash	%	examples/AdvancedChatServer RAM for global variables	%	examples/BarometricPressureWebServer flash	%	examples/BarometricPressureWebServer RAM for global variables	%	examples/ChatServer flash	%	examples/ChatServer RAM for global variables	%	examples/DhcpAddressPrinter flash	%	examples/DhcpAddressPrinter RAM for global variables	%	examples/DhcpChatServer flash	%	examples/DhcpChatServer RAM for global variables	%	examples/LinkStatus flash	%	examples/LinkStatus RAM for global variables	%	examples/PagerServer flash	%	examples/PagerServer RAM for global variables	%	examples/TelnetClient flash	%	examples/TelnetClient RAM for global variables	%	examples/UDPSendReceiveString flash	%	examples/UDPSendReceiveString RAM for global variables	%	examples/UdpNtpClient flash	%	examples/UdpNtpClient RAM for global variables	%	examples/WebClient flash	%	examples/WebClient RAM for global variables	%	examples/WebClientRepeating flash	%	examples/WebClientRepeating RAM for global variables	%	examples/WebServer flash	%	examples/WebServer RAM for global variables	%
arduino:avr:leonardo	-14	-0.05	0	0.0	-14	-0.05	0	0.0	-14	-0.05	0	0.0	0	0.0	0	0.0	-14	-0.05	0	0.0	0	0.0	0	0.0	-14	-0.05	0	0.0	-10	-0.03	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-10	-0.03	0	0.0	-10	-0.03	0	0.0	-14	-0.05	0	0.0
arduino:avr:mega	-14	-0.01	0	0.0	-14	-0.01	0	0.0	-14	-0.01	0	0.0	0	0.0	0	0.0	-14	-0.01	0	0.0	0	0.0	0	0.0	-14	-0.01	0	0.0	-10	-0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-10	-0.0	0	0.0	-10	-0.0	0	0.0	-14	-0.01	0	0.0
arduino:avr:nano	-14	-0.05	0	0.0	-14	-0.05	0	0.0	-14	-0.05	0	0.0	0	0.0	0	0.0	-14	-0.05	0	0.0	0	0.0	0	0.0	-14	-0.05	0	0.0	-10	-0.03	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-10	-0.03	0	0.0	-10	-0.03	0	0.0	-14	-0.05	0	0.0
arduino:megaavr:nona4809	-14	-0.03	0	0.0	-14	-0.03	0	0.0	-14	-0.03	0	0.0	0	0.0	0	0.0	-14	-0.03	0	0.0	0	0.0	0	0.0	-14	-0.03	0	0.0	8	0.02	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	8	0.02	0	0.0	8	0.02	0	0.0	-14	-0.03	0	0.0
arduino:megaavr:uno2018	-14	-0.03	0	0.0	-14	-0.03	0	0.0	-14	-0.03	0	0.0	0	0.0	0	0.0	-14	-0.03	0	0.0	0	0.0	0	0.0	-14	-0.03	0	0.0	8	0.02	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	8	0.02	0	0.0	8	0.02	0	0.0	-14	-0.03	0	0.0
arduino:sam:arduino_due_x_dbg	-8	-0.0	N/A	N/A	-8	-0.0	N/A	N/A	-8	-0.0	N/A	N/A	0	0.0	N/A	N/A	-8	-0.0	N/A	N/A	0	0.0	N/A	N/A	-8	-0.0	N/A	N/A	-8	-0.0	N/A	N/A	0	0.0	N/A	N/A	0	0.0	N/A	N/A	-8	-0.0	N/A	N/A	-8	-0.0	N/A	N/A	-8	-0.0	N/A	N/A
arduino:samd:arduino_zero_edbg	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0
arduino:samd:mkr1000	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0
arduino:samd:mkrfox1200	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0
arduino:samd:mkrgsm1400	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0
arduino:samd:mkrnb1500	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0
arduino:samd:mkrvidor4000	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0
arduino:samd:mkrwan1300	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0
arduino:samd:mkrwan1310	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0
arduino:samd:mkrwifi1010	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0
arduino:samd:mkrzero	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0
arduino:samd:nano_33_iot	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	0	0.0	0	0.0	0	0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0	-4	-0.0	0	0.0

Click for full report CSV

Board,examples/AdvancedChatServer<br>flash,%,examples/AdvancedChatServer<br>RAM for global variables,%,examples/BarometricPressureWebServer<br>flash,%,examples/BarometricPressureWebServer<br>RAM for global variables,%,examples/ChatServer<br>flash,%,examples/ChatServer<br>RAM for global variables,%,examples/DhcpAddressPrinter<br>flash,%,examples/DhcpAddressPrinter<br>RAM for global variables,%,examples/DhcpChatServer<br>flash,%,examples/DhcpChatServer<br>RAM for global variables,%,examples/LinkStatus<br>flash,%,examples/LinkStatus<br>RAM for global variables,%,examples/PagerServer<br>flash,%,examples/PagerServer<br>RAM for global variables,%,examples/TelnetClient<br>flash,%,examples/TelnetClient<br>RAM for global variables,%,examples/UDPSendReceiveString<br>flash,%,examples/UDPSendReceiveString<br>RAM for global variables,%,examples/UdpNtpClient<br>flash,%,examples/UdpNtpClient<br>RAM for global variables,%,examples/WebClient<br>flash,%,examples/WebClient<br>RAM for global variables,%,examples/WebClientRepeating<br>flash,%,examples/WebClientRepeating<br>RAM for global variables,%,examples/WebServer<br>flash,%,examples/WebServer<br>RAM for global variables,%
arduino:avr:leonardo,-14,-0.05,0,0.0,-14,-0.05,0,0.0,-14,-0.05,0,0.0,0,0.0,0,0.0,-14,-0.05,0,0.0,0,0.0,0,0.0,-14,-0.05,0,0.0,-10,-0.03,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-10,-0.03,0,0.0,-10,-0.03,0,0.0,-14,-0.05,0,0.0
arduino:avr:mega,-14,-0.01,0,0.0,-14,-0.01,0,0.0,-14,-0.01,0,0.0,0,0.0,0,0.0,-14,-0.01,0,0.0,0,0.0,0,0.0,-14,-0.01,0,0.0,-10,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-10,-0.0,0,0.0,-10,-0.0,0,0.0,-14,-0.01,0,0.0
arduino:avr:nano,-14,-0.05,0,0.0,-14,-0.05,0,0.0,-14,-0.05,0,0.0,0,0.0,0,0.0,-14,-0.05,0,0.0,0,0.0,0,0.0,-14,-0.05,0,0.0,-10,-0.03,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-10,-0.03,0,0.0,-10,-0.03,0,0.0,-14,-0.05,0,0.0
arduino:megaavr:nona4809,-14,-0.03,0,0.0,-14,-0.03,0,0.0,-14,-0.03,0,0.0,0,0.0,0,0.0,-14,-0.03,0,0.0,0,0.0,0,0.0,-14,-0.03,0,0.0,8,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,8,0.02,0,0.0,8,0.02,0,0.0,-14,-0.03,0,0.0
arduino:megaavr:uno2018,-14,-0.03,0,0.0,-14,-0.03,0,0.0,-14,-0.03,0,0.0,0,0.0,0,0.0,-14,-0.03,0,0.0,0,0.0,0,0.0,-14,-0.03,0,0.0,8,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,8,0.02,0,0.0,8,0.02,0,0.0,-14,-0.03,0,0.0
arduino:sam:arduino_due_x_dbg,-8,-0.0,N/A,N/A,-8,-0.0,N/A,N/A,-8,-0.0,N/A,N/A,0,0.0,N/A,N/A,-8,-0.0,N/A,N/A,0,0.0,N/A,N/A,-8,-0.0,N/A,N/A,-8,-0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,-8,-0.0,N/A,N/A,-8,-0.0,N/A,N/A,-8,-0.0,N/A,N/A
arduino:samd:arduino_zero_edbg,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0
arduino:samd:mkr1000,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0
arduino:samd:mkrfox1200,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0
arduino:samd:mkrgsm1400,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0
arduino:samd:mkrnb1500,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0
arduino:samd:mkrvidor4000,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0
arduino:samd:mkrwan1300,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0
arduino:samd:mkrwan1310,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0
arduino:samd:mkrwifi1010,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0
arduino:samd:mkrzero,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0
arduino:samd:nano_33_iot,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0,-4,-0.0,0,0.0