Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix of bounds memset #216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix of bounds memset #216

wants to merge 1 commit into from
+5 −2

Conversation

technyon
Copy link

Fixes issue #45

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

Memory usage change @ 39be07e

Board flash % RAM for global variables %
arduino:avr:leonardo 🔺 0 - +64 0.0 - +0.22 0 - 0 0.0 - 0.0
arduino:avr:mega 🔺 0 - +64 0.0 - +0.03 0 - 0 0.0 - 0.0
arduino:avr:nano 🔺 0 - +64 0.0 - +0.21 0 - 0 0.0 - 0.0
arduino:megaavr:nona4809 🔺 0 - +78 0.0 - +0.16 0 - 0 0.0 - 0.0
arduino:megaavr:uno2018 🔺 0 - +78 0.0 - +0.16 0 - 0 0.0 - 0.0
arduino:sam:arduino_due_x_dbg 🔺 0 - +56 0.0 - +0.01 N/A N/A
arduino:samd:arduino_zero_edbg 🔺 0 - +52 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 0 - +52 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrfox1200 🔺 0 - +52 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 0 - +52 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 🔺 0 - +52 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrvidor4000 🔺 0 - +52 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 🔺 0 - +52 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1310 🔺 0 - +52 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +52 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrzero 🔺 0 - +52 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 🔺 0 - +52 0.0 - +0.02 0 - 0 0.0 - 0.0
Click for full report table
Board examples/AdvancedChatServer
flash		 % examples/AdvancedChatServer
RAM for global variables		 % examples/BarometricPressureWebServer
flash		 % examples/BarometricPressureWebServer
RAM for global variables		 % examples/ChatServer
flash		 % examples/ChatServer
RAM for global variables		 % examples/DhcpAddressPrinter
flash		 % examples/DhcpAddressPrinter
RAM for global variables		 % examples/DhcpChatServer
flash		 % examples/DhcpChatServer
RAM for global variables		 % examples/LinkStatus
flash		 % examples/LinkStatus
RAM for global variables		 % examples/PagerServer
flash		 % examples/PagerServer
RAM for global variables		 % examples/TelnetClient
flash		 % examples/TelnetClient
RAM for global variables		 % examples/UDPSendReceiveString
flash		 % examples/UDPSendReceiveString
RAM for global variables		 % examples/UdpNtpClient
flash		 % examples/UdpNtpClient
RAM for global variables		 % examples/WebClient
flash		 % examples/WebClient
RAM for global variables		 % examples/WebClientRepeating
flash		 % examples/WebClientRepeating
RAM for global variables		 % examples/WebServer
flash		 % examples/WebServer
RAM for global variables		 %
arduino:avr:leonardo 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 58 0.2 0 0.0 60 0.21 0 0.0 0 0.0 0 0.0 56 0.2 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 64 0.22 0 0.0 56 0.2 0 0.0 56 0.2 0 0.0 0 0.0 0 0.0
arduino:avr:mega 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 60 0.02 0 0.0 60 0.02 0 0.0 0 0.0 0 0.0 56 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 64 0.03 0 0.0 56 0.02 0 0.0 56 0.02 0 0.0 0 0.0 0 0.0
arduino:avr:nano 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 58 0.19 0 0.0 60 0.2 0 0.0 0 0.0 0 0.0 56 0.18 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 64 0.21 0 0.0 56 0.18 0 0.0 56 0.18 0 0.0 0 0.0 0 0.0
arduino:megaavr:nona4809 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 78 0.16 0 0.0 74 0.15 0 0.0 0 0.0 0 0.0 48 0.1 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 62 0.13 0 0.0 48 0.1 0 0.0 48 0.1 0 0.0 0 0.0 0 0.0
arduino:megaavr:uno2018 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 78 0.16 0 0.0 74 0.15 0 0.0 0 0.0 0 0.0 48 0.1 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 62 0.13 0 0.0 48 0.1 0 0.0 48 0.1 0 0.0 0 0.0 0 0.0
arduino:sam:arduino_due_x_dbg 0 0.0 N/A N/A 0 0.0 N/A N/A 0 0.0 N/A N/A 56 0.01 N/A N/A 56 0.01 N/A N/A 0 0.0 N/A N/A 56 0.01 N/A N/A 0 0.0 N/A N/A 0 0.0 N/A N/A 56 0.01 N/A N/A 56 0.01 N/A N/A 56 0.01 N/A N/A 0 0.0 N/A N/A
arduino:samd:arduino_zero_edbg 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0
arduino:samd:mkrfox1200 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0
arduino:samd:mkrnb1500 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0
arduino:samd:mkrvidor4000 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1310 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0
arduino:samd:mkrzero 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 52 0.02 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/AdvancedChatServer<br>flash,%,examples/AdvancedChatServer<br>RAM for global variables,%,examples/BarometricPressureWebServer<br>flash,%,examples/BarometricPressureWebServer<br>RAM for global variables,%,examples/ChatServer<br>flash,%,examples/ChatServer<br>RAM for global variables,%,examples/DhcpAddressPrinter<br>flash,%,examples/DhcpAddressPrinter<br>RAM for global variables,%,examples/DhcpChatServer<br>flash,%,examples/DhcpChatServer<br>RAM for global variables,%,examples/LinkStatus<br>flash,%,examples/LinkStatus<br>RAM for global variables,%,examples/PagerServer<br>flash,%,examples/PagerServer<br>RAM for global variables,%,examples/TelnetClient<br>flash,%,examples/TelnetClient<br>RAM for global variables,%,examples/UDPSendReceiveString<br>flash,%,examples/UDPSendReceiveString<br>RAM for global variables,%,examples/UdpNtpClient<br>flash,%,examples/UdpNtpClient<br>RAM for global variables,%,examples/WebClient<br>flash,%,examples/WebClient<br>RAM for global variables,%,examples/WebClientRepeating<br>flash,%,examples/WebClientRepeating<br>RAM for global variables,%,examples/WebServer<br>flash,%,examples/WebServer<br>RAM for global variables,%
arduino:avr:leonardo,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,58,0.2,0,0.0,60,0.21,0,0.0,0,0.0,0,0.0,56,0.2,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.22,0,0.0,56,0.2,0,0.0,56,0.2,0,0.0,0,0.0,0,0.0
arduino:avr:mega,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,60,0.02,0,0.0,60,0.02,0,0.0,0,0.0,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.03,0,0.0,56,0.02,0,0.0,56,0.02,0,0.0,0,0.0,0,0.0
arduino:avr:nano,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,58,0.19,0,0.0,60,0.2,0,0.0,0,0.0,0,0.0,56,0.18,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,64,0.21,0,0.0,56,0.18,0,0.0,56,0.18,0,0.0,0,0.0,0,0.0
arduino:megaavr:nona4809,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,78,0.16,0,0.0,74,0.15,0,0.0,0,0.0,0,0.0,48,0.1,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,62,0.13,0,0.0,48,0.1,0,0.0,48,0.1,0,0.0,0,0.0,0,0.0
arduino:megaavr:uno2018,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,78,0.16,0,0.0,74,0.15,0,0.0,0,0.0,0,0.0,48,0.1,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,62,0.13,0,0.0,48,0.1,0,0.0,48,0.1,0,0.0,0,0.0,0,0.0
arduino:sam:arduino_due_x_dbg,0,0.0,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,56,0.01,N/A,N/A,56,0.01,N/A,N/A,0,0.0,N/A,N/A,56,0.01,N/A,N/A,0,0.0,N/A,N/A,0,0.0,N/A,N/A,56,0.01,N/A,N/A,56,0.01,N/A,N/A,56,0.01,N/A,N/A,0,0.0,N/A,N/A
arduino:samd:arduino_zero_edbg,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0
arduino:samd:mkrfox1200,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0
arduino:samd:mkrgsm1400,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0
arduino:samd:mkrvidor4000,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0
arduino:samd:mkrzero,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,52,0.02,0,0.0,0,0.0,0,0.0

@per1234 per1234 linked an issue Jan 31, 2023 that may be closed by this pull request
Overflow memset in Dhcp.cpp #45
Open
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overflow memset in Dhcp.cpp
3 participants
@technyon @CLAassistant @per1234