Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCD println does not go to a new line #45

Open
per1234 opened this issue Mar 28, 2021 · 4 comments
Open

LCD println does not go to a new line #45

per1234 opened this issue Mar 28, 2021 · 4 comments
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@per1234
Copy link
Contributor

per1234 commented Mar 28, 2021

Moved from arduino/Arduino#2191 by @anthony-ngu

The LiquidCrystal Library should handle '\r' and '\n' characters properly.

When a println is used, it sends both the \r and \n characters and the LiquidCrystal library prints those characters out. Instead it should set the cursor to a row below.

@per1234 per1234 added the type: enhancement Proposed improvement label Mar 28, 2021
@per1234
Copy link
Contributor Author

per1234 commented Mar 28, 2021

From agdl on 2015-01-12:

@anthony-ngu The LCD controller prints on the LCD everything you do to it so it is normal that you get those characters. In order to change line you have to set the cursor to the new line using setCursor()

@per1234
Copy link
Contributor Author

per1234 commented Mar 28, 2021

From JulyJim on 2015-01-12:

agdl Your "answer" is correct, but closing the issue is questionable.
Most "Arduino libraries" are build as simple stand alone code thus their integration into projects needs some work. Nothing wrong with that. However, C++ has a feature called "inheritance" which is seldom implemented in these add-on libraries.
I realize using inheritance from Print class would made for additional work for the author of LiquidCrystal but would "upgrade" Arduino from "blink without delay" toy to powerful processor.

@per1234
Copy link
Contributor Author

per1234 commented Mar 28, 2021

From agdl on 2015-01-12:

@VaclavSal I reopen it, but i think that since this issue is here from 18th of july and nobody worked on it since you can simply place a setCursor, it will stay here for good..

@per1234
Copy link
Contributor Author

per1234 commented Mar 28, 2021

From benjaminmordaunt on 2021-03-24

I realize using inheritance from Print class would made for additional work for the author of LiquidCrystal but would "upgrade" Arduino from "blink without delay" toy to powerful processor.

JulyJim
cmaglie

There's an awful lot more work needed in both Arduino standard library code quality and documentation before that jump will happen. Also, inheritance from any standard printing class in Arduino core wouldn't make sense.

The buffering techniques used here mean text is handed line-by-line, with buffers having no knowledge of the line beneath/above them. Changing this has major implications in features such as text scrolling, too. This should be closed.

@per1234 per1234 added the topic: code Related to content of the project itself label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

No branches or pull requests

1 participant