Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'if' statement at WifiClient.cpp:149 is useless #304

Open
denisbaylor opened this issue Jan 2, 2021 · 1 comment
Open

'if' statement at WifiClient.cpp:149 is useless #304

denisbaylor opened this issue Jan 2, 2021 · 1 comment
Labels
type: imperfection Perceived defect in any part of project

Comments

@denisbaylor
Copy link

It can only set a variable 'size_tmp' which is never read again.

Perhaps the original intent was to use size_tmp at line 153, but it looks like that function does its own bounds checking.
@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Jan 2, 2021
@JAndrassy
Copy link

it doesn't cause a bug because the check for max size is in WiFiSocket.read.
But yes, size_tmp is useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@per1234 @JAndrassy @denisbaylor