Set up automatic building #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kichura
suggested changes
Feb 7, 2023
.github/workflows/build.yml
Outdated
| with: | ||
| name: jars | ||
| path: build/libs | ||
| if-no-files-found: error |
There was a problem hiding this comment.
Should be "warn" instead of error because otherwise, it would always assume compilation failed.
There was a problem hiding this comment.
Fixed, but I used error so that if building jars didn't produce any jars, the build would tell you that something is wrong.
.github/workflows/build.yml
Outdated
| - name: Validate Gradle wrapper | ||
| uses: gradle/wrapper-validation-action@v1 | ||
| - name: Install Java 17 | ||
| uses: actions/setup-java@v3.9.0 |
There was a problem hiding this comment.
No need to use ".9.0" in setup-java context.
.github/workflows/build.yml
Outdated
| uses: actions/setup-java@v3.9.0 | ||
| with: | ||
| java-version: 17 # Can be more specific if neccesary | ||
| distribution: adopt |
There was a problem hiding this comment.
"temurin" should go here instead of adopt.
.github/workflows/build.yml
Outdated
| - uses: actions/checkout@v2 | ||
| - uses: gradle/wrapper-validation-action@v1 | ||
| - name: Checkout | ||
| uses: actions/checkout@v2 |
PoolloverNathan
force-pushed
the
gh-actions
branch
from
0089903
to
d1c9e0e
Compare
This commit adds multiple actions to build.yml that download java 17, build the mod, and upload the jars to Github Actions.
PoolloverNathan
force-pushed
the
gh-actions
branch
from
d1c9e0e
to
241049a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request sets up automated compiling and building via Github Actions. The action will create an artifact named "jars" that contains both the distribution jar and the sources jar. To see what the build process looks like, approve this workflow.
This pull request is best suited for rebasing due to only containing a single commit.