-
-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BATTERY_STATE for cellCount #3964
Conversation
haslinghuis
commented
May 15, 2024
- Fixes: configurator battery gauge does not follow force_battery_cell_count #3963
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Maybe then we can remove this?
I think we don't support old versions anymore, so better to clean all this. |
The idea was to remove the constant completely. The MSP message contains one variable that directly indicates if there is battery or not. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Not tested but looks good to me.
no idea when i'll get to test with battery, request other testers. |
Instead of calculating cell count we use cell count from firmware like used in pid profile cell count switching. |