Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to remove building with nw.js #3967

Merged
merged 1 commit into from
May 20, 2024

Conversation

McGiverGim
Copy link
Member

Updates and completes the README to make clear that we are moving to PWA, updates the "master" snapshots URL and the instructions for building.

Copy link

netlify bot commented May 16, 2024

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit d47da6f
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/66460c1e02ce1f0008f9e2ab
😎 Deploy Preview https://deploy-preview-3967.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@haslinghuis haslinghuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@McGiverGim
Copy link
Member Author

I didn't notice it... moved upper and updated.

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
9.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@nerdCopter
Copy link
Member

nerdCopter commented May 17, 2024

off-subject:
i noticed that https://app.betaflight.com/ and https://master.dev.app.betaflight.com/ are at the same commit (after browser refresh)
will there be a separation of stable vs master at some point @blckmn ?

@nerdCopter
Copy link
Member

maybe the new PWA information should be top of readme with "note" alert/admonition syntax.

https://github.com/orgs/community/discussions/16925

@McGiverGim
Copy link
Member Author

The idea of this PR is to create a transition readme, for this reason I have not added the future stable URL.
For the same reason I restricted the PWA information to where is needed, to not confuse non developers users. For this reason I think it's good at this point not add this info on the top.

@haslinghuis haslinghuis merged commit 5994e73 into betaflight:master May 20, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants