Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OSD warning for vTX "device ready: no" #13415

Open
joshuabardwell opened this issue Mar 3, 2024 · 2 comments · May be fixed by #13422
Open

Add OSD warning for vTX "device ready: no" #13415

joshuabardwell opened this issue Mar 3, 2024 · 2 comments · May be fixed by #13422
Labels
Feature Request Feature requests are excluded from automatically being marked as stale

Comments

@joshuabardwell
Copy link
Contributor

Is your feature request related to a problem? Please describe

Currently, Betaflight has no OSD warning if the SmartAudio (or other protocol) connection to the vTX is down. As a result, users may see TX power, band, and channel in the OSD when those values are not correct. This can result in the user flying away and losing video unexpectedly (e.g. the vTX is at 25 mW or in pit mode, or the vTX is on an adjacent channel).

Describe the solution you'd like

Add a new Warning message in the OSD for when the FC has "Device Ready: No" status to the vTX. Currently, the configurator shows this status, so it should be possible for the FC to evaluate this status.

In the vTX settings OSD menu, add a message on screen to clealry indicate "VTX OFFLINE" or something like that, so the user can know that the changes they are making in the FC config will not be received by the vTX.

Describe alternatives you've considered

None

Other information

None
@joshuabardwell joshuabardwell added the Template: Feature Request Set by auto_close_issue. label Mar 3, 2024
@joshuabardwell
Copy link
Contributor Author

joshuabardwell commented Mar 3, 2024 •
edited

This warning status should not prevent arming, since users may choose to manually set the vTX settings via button press, or users may fly LOS or the vTX may be temporarily powered down. But it shouldn't be possible for them to take off without knowing that their assumptions about the vTX may be wrong.

I mean... I guess if you wanted to be extra, you could have an option to prevent arming if vTX disabled. But I'm not sure who would use it.

@haslinghuis haslinghuis added Feature Request Feature requests are excluded from automatically being marked as stale and removed Template: Feature Request Set by auto_close_issue. labels Mar 3, 2024
@bigspeedfpv
Copy link

this seems pretty trivial to implement - I could probably cook something up tomorrow (assuming nobody more familiar with betaflight beats me to it)

to be clear, I haven't used the OSD menus for VTX control aside from HDZero in a while - doesn't the SmartAudio menu already show something different (statx or something?) when your VTX isn't connected?

also, would it be worth adding as an LED warning of some sort? It could be useful to have as a way to troubleshoot no video (VTX connection issue vs pit mode for example) but it would also add to the clutter of LED codes that are already there

@bigspeedfpv bigspeedfpv linked a pull request Mar 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Feature requests are excluded from automatically being marked as stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add VTX Offline warning in OSD bigspeedfpv/betaflight
3 participants
@joshuabardwell @haslinghuis @bigspeedfpv