Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blackbox altitude units for GPS-track #13586

Closed
HereticToXa opened this issue Apr 26, 2024 · 7 comments
Closed

Blackbox altitude units for GPS-track #13586

HereticToXa opened this issue Apr 26, 2024 · 7 comments
Labels
Feature Request Feature requests are excluded from automatically being marked as stale

Comments

@HereticToXa
Copy link

Is your feature request related to a problem? Please describe

After decoding blackbox log from Betaflight the gpx file contain information about altitude in wrong units.

Describe the solution you'd like

It seems like it should be multiplied by 0,1.
So the scale is just off by one decimal.

Describe alternatives you've considered

CLI command for choosing the right units.

Other information

There were some requests for it, but it was closed somehow. And I heard INav have no such a problem.

@HereticToXa HereticToXa added the Template: Feature Request Set by auto_close_issue. label Apr 26, 2024
@haslinghuis haslinghuis added Feature Request Feature requests are excluded from automatically being marked as stale and removed Template: Feature Request Set by auto_close_issue. labels Apr 29, 2024
@jannikbecher
Copy link

Hey @HereticToXa :)

The altitude is saved as an integer with 0.01m resolution

/* LLH Location in NEU axis system */
typedef struct gpsLocation_s {
int32_t lat; // latitude * 1e+7
int32_t lon; // longitude * 1e+7
int32_t altCm; // altitude in 0.01m
} gpsLocation_t;

and written to the blackbox with 0.1m resolution

blackboxWriteSignedVB(gpsSol.llh.altCm / 10); // log altitude in increments of 0.1m

so this is wanted behaviour.

@jannikbecher
Copy link

I submitted a PR in the log viewer to fix the GPX output

@HereticToXa
Copy link
Author

Thanks, but in BF 4.5 this "bug" was fixed i think. Now export gpx from blackbox explorer works great

@jannikbecher
Copy link

Ok perfect, so the issue can be closed? :)

@HereticToXa
Copy link
Author

Well. I'm not sure, because not everybody will update to betaflight 4.5 to fix this issue. So I think it must be fixed anyway

@haslinghuis
Copy link
Member

Both snippets above were there at least since firmware 4.0

@HereticToXa
Copy link
Author

O, yeah? And why on 4.3 many people got this error in vertical scale after exporting gpx from blackbox logs? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Feature requests are excluded from automatically being marked as stale
Projects
None yet
Development

No branches or pull requests

3 participants